From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>,
Peter Maydell <peter.maydell@linaro.org>,
Pan Nengyuan <pannengyuan@huawei.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PULL v2 13/17] virtio-scsi: convert to new virtio_delete_queue
Date: Wed, 22 Jan 2020 01:50:25 -0500 [thread overview]
Message-ID: <20200122064907.512501-14-mst@redhat.com> (raw)
In-Reply-To: <20200122064907.512501-1-mst@redhat.com>
From: Pan Nengyuan <pannengyuan@huawei.com>
Use virtio_delete_queue to make it more clear.
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Message-Id: <20200117075547.60864-3-pannengyuan@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/scsi/virtio-scsi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index 858b3aaccb..d3af42ef92 100644
--- a/hw/scsi/virtio-scsi.c
+++ b/hw/scsi/virtio-scsi.c
@@ -945,10 +945,10 @@ void virtio_scsi_common_unrealize(DeviceState *dev)
VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(dev);
int i;
- virtio_del_queue(vdev, 0);
- virtio_del_queue(vdev, 1);
+ virtio_delete_queue(vs->ctrl_vq);
+ virtio_delete_queue(vs->event_vq);
for (i = 0; i < vs->conf.num_queues; i++) {
- virtio_del_queue(vdev, i + 2);
+ virtio_delete_queue(vs->cmd_vqs[i]);
}
g_free(vs->cmd_vqs);
virtio_cleanup(vdev);
--
MST
next prev parent reply other threads:[~2020-01-22 7:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 6:49 [PULL v2 00/17] virtio, pc: fixes, features Michael S. Tsirkin
2020-01-22 6:49 ` [PULL v2 01/17] q35: implement 128K SMRAM at default SMBASE address Michael S. Tsirkin
2020-01-22 6:49 ` [PULL v2 02/17] tests: q35: MCH: add default SMBASE SMRAM lock test Michael S. Tsirkin
2020-01-22 6:49 ` [PULL v2 03/17] acpi: cpuhp: spec: clarify 'CPU selector' register usage and endianness Michael S. Tsirkin
2020-01-22 6:50 ` [PULL v2 04/17] acpi: cpuhp: spec: fix 'Command data' description Michael S. Tsirkin
2020-01-22 6:50 ` [PULL v2 05/17] acpi: cpuhp: spec: clarify store into 'Command data' when 'Command field' == 0 Michael S. Tsirkin
2020-01-22 6:50 ` [PULL v2 06/17] acpi: cpuhp: introduce 'Command data 2' field Michael S. Tsirkin
2020-01-22 6:50 ` [PULL v2 07/17] acpi: cpuhp: spec: add typical usecases Michael S. Tsirkin
2020-01-22 6:50 ` [PULL v2 08/17] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command Michael S. Tsirkin
2020-01-22 6:50 ` [PULL v2 09/17] bios-tables-test: document expected file update Michael S. Tsirkin
2020-01-22 6:50 ` [PULL v2 10/17] virtio-9p-device: fix memleak in virtio_9p_device_unrealize Michael S. Tsirkin
2020-01-22 6:50 ` [PULL v2 11/17] virtio-9p-device: convert to new virtio_delete_queue Michael S. Tsirkin
2020-01-22 6:50 ` [PULL v2 12/17] virtio-scsi: delete vqs in unrealize to avoid memleaks Michael S. Tsirkin
2020-01-22 6:50 ` Michael S. Tsirkin [this message]
2020-01-22 6:50 ` [PULL v2 14/17] vhost-vsock: delete vqs in vhost_vsock_unrealize " Michael S. Tsirkin
2020-01-22 6:50 ` [PULL v2 15/17] vhost: Add names to section rounded warning Michael S. Tsirkin
2020-01-22 6:50 ` [PULL v2 16/17] vhost: Only align sections for vhost-user Michael S. Tsirkin
2020-01-22 6:50 ` [PULL v2 17/17] i386:acpi: Remove _HID from the SMBus ACPI entry Michael S. Tsirkin
2020-01-22 7:10 ` [PULL v2 00/17] virtio, pc: fixes, features no-reply
2020-01-22 8:07 ` Michael S. Tsirkin
2020-01-23 14:30 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122064907.512501-14-mst@redhat.com \
--to=mst@redhat.com \
--cc=fam@euphon.net \
--cc=pannengyuan@huawei.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).