qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>
Subject: [PATCH 5/5] rebuild-expected-aml.sh: remind about the process
Date: Wed, 22 Jan 2020 03:06:04 -0500	[thread overview]
Message-ID: <20200122080538.591734-6-mst@redhat.com> (raw)
In-Reply-To: <20200122080538.591734-1-mst@redhat.com>

Remind users of rebuild-expected-aml.sh about the process
to follow. Suppress the warning if allowed file list exists -
that's a big hint user is already aware of the process.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 tests/data/acpi/rebuild-expected-aml.sh | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/acpi/rebuild-expected-aml.sh
index d44e511533..9cbaab1a4d 100755
--- a/tests/data/acpi/rebuild-expected-aml.sh
+++ b/tests/data/acpi/rebuild-expected-aml.sh
@@ -31,6 +31,13 @@ done
 
 eval `grep SRC_PATH= config-host.mak`
 
+old_allowed_dif=`grep -v -e 'List of comma-separated changed AML files to ignore' ${SRC_PATH}/tests/qtest/bios-tables-test-allowed-diff.h`
+
 echo '/* List of comma-separated changed AML files to ignore */' > ${SRC_PATH}/tests/qtest/bios-tables-test-allowed-diff.h
 
 echo "The files were rebuilt and can be added to git."
+
+if [ -z "$old_allowed_dif" ]; then
+    echo "Note! Please do not commit expected files with source changes"
+    echo "Note! Please follow the process documented in ${SRC_PATH}/tests/qtest/bios-tables-test.c"
+fi
-- 
MST



      parent reply	other threads:[~2020-01-22  8:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22  8:05 [PATCH 0/5] bios-tables-test: more documentation Michael S. Tsirkin
2020-01-22  8:05 ` [PATCH 1/5] bios-tables-test: tell people how to update Michael S. Tsirkin
2020-01-22  8:25   ` Laurent Vivier
2020-01-22  9:17   ` Thomas Huth
2020-01-22  8:05 ` [PATCH 2/5] bios-tables-test: fix up DIFF generation Michael S. Tsirkin
2020-01-22  9:00   ` Laurent Vivier
2020-01-22  9:13     ` Michael S. Tsirkin
2020-01-22  8:05 ` [PATCH 3/5] bios-tables-test: default diff command Michael S. Tsirkin
2020-01-22  8:06 ` [PATCH 4/5] bios-tables-test: fix path to allowed diff Michael S. Tsirkin
2020-01-22  8:51   ` Laurent Vivier
2020-01-22  9:18   ` Thomas Huth
2020-01-22  8:06 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200122080538.591734-6-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).