From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 849ADC2D0DB for ; Wed, 22 Jan 2020 16:51:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CC4621569 for ; Wed, 22 Jan 2020 16:51:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Jz29yMsv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CC4621569 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuJEK-0003vK-4k for qemu-devel@archiver.kernel.org; Wed, 22 Jan 2020 11:51:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50149) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuJ8Y-0007hW-SW for qemu-devel@nongnu.org; Wed, 22 Jan 2020 11:45:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuJ8X-0000jn-L7 for qemu-devel@nongnu.org; Wed, 22 Jan 2020 11:45:50 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:52080 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuJ8X-0000jh-I3 for qemu-devel@nongnu.org; Wed, 22 Jan 2020 11:45:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579711549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=djdp+4clCO9SYGk3oJ2e6PEL7oywnDS2eZkeWHzh/W8=; b=Jz29yMsvythwtD6uKQ+9LBS0WZZSM8hsrQPJvxAjBdt8GRVsWYX/NeCm+yrj5Ux+Ofu6us mMNDzrybsrhTzbfsTnVhqaF5VJSLkplMzXsFEPPyG5oinC+cSPJr/Cd4BXnrSELx5ETTUJ KV8OPF71DUK3VVrs3d3jC8zQ476CryA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-212-Xw9wfa4dPAeij-cZ6vJhzQ-1; Wed, 22 Jan 2020 11:45:45 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5943D8010E8; Wed, 22 Jan 2020 16:45:44 +0000 (UTC) Received: from localhost (unknown [10.36.118.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DB78E19C69; Wed, 22 Jan 2020 16:45:43 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v2 3/5] file-posix: Drop hdev_co_create_opts() Date: Wed, 22 Jan 2020 17:45:30 +0100 Message-Id: <20200122164532.178040-4-mreitz@redhat.com> In-Reply-To: <20200122164532.178040-1-mreitz@redhat.com> References: <20200122164532.178040-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: Xw9wfa4dPAeij-cZ6vJhzQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Maxim Levitsky , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The generic fallback implementation effectively does the same. Reviewed-by: Maxim Levitsky Signed-off-by: Max Reitz --- block/file-posix.c | 67 ---------------------------------------------- 1 file changed, 67 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 1b805bd938..fd29372599 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -3418,67 +3418,6 @@ static coroutine_fn int hdev_co_pwrite_zeroes(BlockD= riverState *bs, return raw_do_pwrite_zeroes(bs, offset, bytes, flags, true); } =20 -static int coroutine_fn hdev_co_create_opts(const char *filename, QemuOpts= *opts, - Error **errp) -{ - int fd; - int ret =3D 0; - struct stat stat_buf; - int64_t total_size =3D 0; - bool has_prefix; - - /* This function is used by both protocol block drivers and therefore = either - * of these prefixes may be given. - * The return value has to be stored somewhere, otherwise this is an e= rror - * due to -Werror=3Dunused-value. */ - has_prefix =3D - strstart(filename, "host_device:", &filename) || - strstart(filename, "host_cdrom:" , &filename); - - (void)has_prefix; - - ret =3D raw_normalize_devicepath(&filename, errp); - if (ret < 0) { - return ret; - } - - /* Read out options */ - total_size =3D ROUND_UP(qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0)= , - BDRV_SECTOR_SIZE); - - fd =3D qemu_open(filename, O_WRONLY | O_BINARY); - if (fd < 0) { - ret =3D -errno; - error_setg_errno(errp, -ret, "Could not open device"); - return ret; - } - - if (fstat(fd, &stat_buf) < 0) { - ret =3D -errno; - error_setg_errno(errp, -ret, "Could not stat device"); - } else if (!S_ISBLK(stat_buf.st_mode) && !S_ISCHR(stat_buf.st_mode)) { - error_setg(errp, - "The given file is neither a block nor a character devi= ce"); - ret =3D -ENODEV; - } else if (lseek(fd, 0, SEEK_END) < total_size) { - error_setg(errp, "Device is too small"); - ret =3D -ENOSPC; - } - - if (!ret && total_size) { - uint8_t buf[BDRV_SECTOR_SIZE] =3D { 0 }; - int64_t zero_size =3D MIN(BDRV_SECTOR_SIZE, total_size); - if (lseek(fd, 0, SEEK_SET) =3D=3D -1) { - ret =3D -errno; - } else { - ret =3D qemu_write_full(fd, buf, zero_size); - ret =3D ret =3D=3D zero_size ? 0 : -errno; - } - } - qemu_close(fd); - return ret; -} - static BlockDriver bdrv_host_device =3D { .format_name =3D "host_device", .protocol_name =3D "host_device", @@ -3491,8 +3430,6 @@ static BlockDriver bdrv_host_device =3D { .bdrv_reopen_prepare =3D raw_reopen_prepare, .bdrv_reopen_commit =3D raw_reopen_commit, .bdrv_reopen_abort =3D raw_reopen_abort, - .bdrv_co_create_opts =3D hdev_co_create_opts, - .create_opts =3D &raw_create_opts, .mutable_opts =3D mutable_opts, .bdrv_co_invalidate_cache =3D raw_co_invalidate_cache, .bdrv_co_pwrite_zeroes =3D hdev_co_pwrite_zeroes, @@ -3619,8 +3556,6 @@ static BlockDriver bdrv_host_cdrom =3D { .bdrv_reopen_prepare =3D raw_reopen_prepare, .bdrv_reopen_commit =3D raw_reopen_commit, .bdrv_reopen_abort =3D raw_reopen_abort, - .bdrv_co_create_opts =3D hdev_co_create_opts, - .create_opts =3D &raw_create_opts, .mutable_opts =3D mutable_opts, .bdrv_co_invalidate_cache =3D raw_co_invalidate_cache, =20 @@ -3753,8 +3688,6 @@ static BlockDriver bdrv_host_cdrom =3D { .bdrv_reopen_prepare =3D raw_reopen_prepare, .bdrv_reopen_commit =3D raw_reopen_commit, .bdrv_reopen_abort =3D raw_reopen_abort, - .bdrv_co_create_opts =3D hdev_co_create_opts, - .create_opts =3D &raw_create_opts, .mutable_opts =3D mutable_opts, =20 .bdrv_co_preadv =3D raw_co_preadv, --=20 2.24.1