From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F2B0C32771 for ; Wed, 22 Jan 2020 22:35:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D49522465A for ; Wed, 22 Jan 2020 22:35:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S7OsV2F1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D49522465A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOaR-0003Eu-EV for qemu-devel@archiver.kernel.org; Wed, 22 Jan 2020 17:34:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33475) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOYh-0001g2-Ui for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuOYg-0001Qc-Ur for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:11 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:20911 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuOYg-0001PT-QQ for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579732390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=quW2yWOs2j+1PNJl1s6nqMfCGNqNDaRH3YTdjFarJ+U=; b=S7OsV2F1BUGj/PQHlM87EXsmzpbC5yczj1jtDCgwEGXLCiTVj83FF/rQTQl8H251xUgVcI +rY5VUL+KtGDpBMihxTWXaLrpJ4MBgewR3wDRU3vWDSLq0V53PjATU809i6QQlLURfuRS5 QDY9Gmrjg4WQW3Ze1rpS5TLl6b29jp4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-89-pg2VDHO9O9eh2hZdXTdIrQ-1; Wed, 22 Jan 2020 17:33:08 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 972238010CA; Wed, 22 Jan 2020 22:33:07 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-78.brq.redhat.com [10.40.204.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 347DC86446; Wed, 22 Jan 2020 22:33:03 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Michael S . Tsirkin" , Denis Plotnikov , qemu-devel@nongnu.org Subject: [PATCH 1/6] tests/acceptance/virtio_seg_max_adjust: Only remove listed machines Date: Wed, 22 Jan 2020 23:32:42 +0100 Message-Id: <20200122223247.30419-2-philmd@redhat.com> In-Reply-To: <20200122223247.30419-1-philmd@redhat.com> References: <20200122223247.30419-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: pg2VDHO9O9eh2hZdXTdIrQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Stefan Hajnoczi , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Do not remove unavailable machines, this fixes: VirtioMaxSegSettingsCheck.test_machine_types: ERROR: list.remove(x): x no= t in list (0.12 s) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/acceptance/virtio_seg_max_adjust.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/v= irtio_seg_max_adjust.py index 5458573138..4a417b8ef5 100755 --- a/tests/acceptance/virtio_seg_max_adjust.py +++ b/tests/acceptance/virtio_seg_max_adjust.py @@ -109,14 +109,15 @@ class VirtioMaxSegSettingsCheck(Test): return False =20 def test_machine_types(self): - # collect all machine types except 'none', 'isapc', 'microvm' + EXCLUDED_MACHINES =3D ['none', 'isapc', 'microvm'] + # collect all machine types except the ones in EXCLUDED_MACHINES with QEMUMachine(self.qemu_bin) as vm: vm.launch() machines =3D [m['name'] for m in vm.command('query-machines')] vm.shutdown() - machines.remove('none') - machines.remove('isapc') - machines.remove('microvm') + for m in EXCLUDED_MACHINES: + if m in machines: + machines.remove(m) =20 for dev_type in DEV_TYPES: # create the list of machine types and their parameters. --=20 2.21.1