qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: Maintainers, please add Message-Id: when merging patches
Date: Thu, 23 Jan 2020 11:17:38 +0000	[thread overview]
Message-ID: <20200123111738.GA691377@stefanha-x1.localdomain> (raw)
In-Reply-To: <871rrqbmr9.fsf@dusky.pond.sub.org>

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

On Thu, Jan 23, 2020 at 09:27:54AM +0100, Markus Armbruster wrote:
> Alex Bennée <alex.bennee@linaro.org> writes:
> 
> > Stefan Hajnoczi <stefanha@gmail.com> writes:
> >
> >> Around 66% of qemu.git commits since v4.1.0 include a Message-Id: tag.  Hooray!
> >>
> >> Message-Id: references the patch email that a commit was merged from.
> >> This information is helpful to anyone wishing to refer back to email
> >> discussions and patch series.
> >
> > So I guess the ones that don't are maintainer originated patches unless
> > you actively rebuild your trees from a posted series?
> 
> I recommend using the exact same workflow for constructing pull requests
> whether you wrote the patches yourself or not.

Yes, that's the approach I follow too.  I use the 'patches' tool to
apply patch series, including my own.

It's necessary to get the Revewied-by:, Tested-by:, etc tags squashed in
automatically anyway.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2020-01-23 11:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 12:02 Maintainers, please add Message-Id: when merging patches Stefan Hajnoczi
2020-01-22 12:28 ` Kevin Wolf
2020-01-23 17:18   ` Kevin Wolf
2020-01-23 21:23     ` Laszlo Ersek
2020-01-24 10:58     ` Stefan Hajnoczi
2020-01-22 12:30 ` Alex Bennée
2020-01-22 13:51   ` Cornelia Huck
2020-01-22 14:10   ` Laszlo Ersek
2020-01-22 18:56     ` Alex Bennée
2020-01-22 19:07       ` Cornelia Huck
2020-01-23  9:41         ` Laszlo Ersek
2020-01-22 14:26   ` Gerd Hoffmann
2020-01-23  8:27   ` Markus Armbruster
2020-01-23 11:17     ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200123111738.GA691377@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).