From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63948C2D0DB for ; Thu, 23 Jan 2020 15:05:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EBA221734 for ; Thu, 23 Jan 2020 15:05:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bxydOZwn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EBA221734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iue2l-0005Yy-Si for qemu-devel@archiver.kernel.org; Thu, 23 Jan 2020 10:05:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50196) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iubcx-0007Tc-Fo for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:30:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iubcv-0000aF-ID for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:30:27 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:48254 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iubcu-0000ZM-CG for qemu-devel@nongnu.org; Thu, 23 Jan 2020 07:30:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579782623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L1yzcOFkErkeI0QUBKNVNW/7umaB4uexDD4bAHoahBQ=; b=bxydOZwnLnZKgp8E0K5OHDxutBRo32HiGLecSsvFKCpDaSq5I664Agi7JFmUxvho19cB4S QIFZvpsVzogqBji6fmVy+XQtakkgxK0kfvkbEf3+jzj0MOvgtFVTbeq9gWg1Q9/l3EAQf+ sk/KK9vZa4R/fm8+DR6bp3h2mCJ9IPU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-X6TQkIpPMX2PEKx1ncCaWw-1; Thu, 23 Jan 2020 07:30:16 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 45205800D53; Thu, 23 Jan 2020 12:30:15 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 24C7D60E1C; Thu, 23 Jan 2020 12:30:13 +0000 (UTC) Date: Thu, 23 Jan 2020 13:30:11 +0100 From: Andrew Jones To: Igor Mammedov Subject: Re: [PATCH REPOST v3 10/80] arm/cubieboard: use memdev for RAM Message-ID: <20200123123011.on7z5bxuhnip5654@kamzik.brq.redhat.com> References: <1579779525-20065-1-git-send-email-imammedo@redhat.com> <1579779525-20065-11-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 In-Reply-To: <1579779525-20065-11-git-send-email-imammedo@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: X6TQkIpPMX2PEKx1ncCaWw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: b.galvani@gmail.com, peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jan 23, 2020 at 12:37:35PM +0100, Igor Mammedov wrote: > memory_region_allocate_system_memory() API is going away, so > replace it with memdev allocated MemoryRegion. The later is > initialized by generic code, so board only needs to opt in > to memdev scheme by providing > MachineClass::default_ram_id > and using MachineState::ram instead of manually initializing > RAM memory region. >=20 > PS: > While at it, get rid of no longer needed CubieBoardState wrapper. >=20 > Signed-off-by: Igor Mammedov > --- > CC: drjones@redhat.com > CC: b.galvani@gmail.com > CC: peter.maydell@linaro.org > CC: qemu-arm@nongnu.org > --- > hw/arm/cubieboard.c | 25 ++++++++----------------- > 1 file changed, 8 insertions(+), 17 deletions(-) > I don't know anything about cubieboard, but I promised Igor to put another pair of eyes on his changes. Looks fine to me. Reviewed-by: Andrew Jones =20