From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 140EFC2D0DB for ; Thu, 23 Jan 2020 20:17:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE7F422522 for ; Thu, 23 Jan 2020 20:17:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FrGNchzz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE7F422522 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuiv8-0007Rp-V4 for qemu-devel@archiver.kernel.org; Thu, 23 Jan 2020 15:17:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42744) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuff8-0006Mw-KC for qemu-devel@nongnu.org; Thu, 23 Jan 2020 11:48:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuff7-0000Mk-BV for qemu-devel@nongnu.org; Thu, 23 Jan 2020 11:48:58 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:41088 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuff7-0000ME-8T for qemu-devel@nongnu.org; Thu, 23 Jan 2020 11:48:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579798136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2dozJRlZa0dl3m3ruapIUDG11IbtPuiqyFeJ966CdXs=; b=FrGNchzzDNOvVRkXFR8HT1xTR0TXnqhcAnJdmiiQ7upKE/jM4TlpnDPGLYnmbjx6oZIyie 2rajtRCnsL7GmnRqqXyoL1WxTiTL7q8LoF/IeLlpUDlkwwi3Wkxw1EaJLmuBWW7LhWLZlb YnZn2+dakp1sR0/xEZETorlEkvRCzHg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-232-Lmt_TQInOhuY67VD8A1icA-1; Thu, 23 Jan 2020 11:48:54 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1ECB31800D78 for ; Thu, 23 Jan 2020 16:48:54 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-116-110.ams2.redhat.com [10.36.116.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6B91A28993; Thu, 23 Jan 2020 16:48:53 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, stefanha@redhat.com Subject: [PULL 106/108] virtiofsd/passthrough_ll: Pass errno to fuse_reply_err() Date: Thu, 23 Jan 2020 16:46:28 +0000 Message-Id: <20200123164630.91498-107-dgilbert@redhat.com> In-Reply-To: <20200123164630.91498-1-dgilbert@redhat.com> References: <20200123164630.91498-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: Lmt_TQInOhuY67VD8A1icA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Xiao Yang lo_copy_file_range() passes -errno to fuse_reply_err() and then fuse_reply_= err() changes it to errno again, so that subsequent fuse_send_reply_iov_nofree() = catches the wrong errno.(i.e. reports "fuse: bad error value: ..."). Make fuse_send_reply_iov_nofree() accept the correct -errno by passing errn= o directly in lo_copy_file_range(). Signed-off-by: Xiao Yang Reviewed-by: Eryu Guan dgilbert: Sent upstream and now Merged as aa1185e153f774f1df65 Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index fc15d61510..e6f2399efc 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -2441,7 +2441,7 @@ static void lo_copy_file_range(fuse_req_t req, fuse_i= no_t ino_in, off_t off_in, =20 res =3D copy_file_range(in_fd, &off_in, out_fd, &off_out, len, flags); if (res < 0) { - fuse_reply_err(req, -errno); + fuse_reply_err(req, errno); } else { fuse_reply_write(req, res); } --=20 2.24.1