From: Guenter Roeck <linux@roeck-us.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3 1/8] dma/pl330: Convert to support tracing
Date: Thu, 23 Jan 2020 08:57:20 -0800 [thread overview]
Message-ID: <20200123165720.GA4805@roeck-us.net> (raw)
In-Reply-To: <CAFEAcA9p7Foko17jTB_GSGLnaQwpJTcf0-qTrJkVWje1jOpq-g@mail.gmail.com>
On Thu, Jan 23, 2020 at 04:23:59PM +0000, Peter Maydell wrote:
> On Thu, 23 Jan 2020 at 15:51, Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > On Thu, 23 Jan 2020 at 05:25, Guenter Roeck <linux@roeck-us.net> wrote:
> > >
> > > Replace debug logging code with tracing.
> > >
> > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> >
> > This turns out not to compile on OSX, which is a bit
> > stricter about format strings:
> >
> > These two:
> >
> > > +pl330_dmald(uint32_t chan, uint32_t addr, uint32_t size, uint32_t num, uint32_t ch) "channel:%"PRId8" address:0x%08"PRIx32" size:0x%"PRIx32" num:%"PRId32"%c"
> >
> > > +pl330_dmast(uint32_t chn, uint32_t addr, uint32_t sz, uint32_t num, uint32_t c) "channel:%"PRId8" address:0x%08"PRIx32" size:0x%"PRIx32" num:%"PRId32" %c"
> >
> > both provoke
> > error: format specifies type 'char' but the argument has type
> > 'uint32_t' (aka 'unsigned int') [-Werror,-Wformat]
> >
> > because of the last argument.
> >
> > Easy fix would seem to be to change 'uint32_t ch' to 'char ch'
> > (the argument is always a literal constant 'Y' or 'N').
>
> The 'chan'/'chn' argument is wrong too -- should be uint8_t
> to match the format string and the type of PL330Chan::tag.
> I'll just fix up the pullreq rather than forcing a respin.
Thanks, and sorry for the trouble.
Guenter
next prev parent reply other threads:[~2020-01-23 19:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 5:25 [PATCH v3 0/8] Fix Exynos4210 DMA support Guenter Roeck
2020-01-23 5:25 ` [PATCH v3 1/8] dma/pl330: Convert to support tracing Guenter Roeck
2020-01-23 15:51 ` Peter Maydell
2020-01-23 16:23 ` Peter Maydell
2020-01-23 16:57 ` Guenter Roeck [this message]
2020-01-23 5:25 ` [PATCH v3 2/8] hw/core/or-irq: Increase limit of or-lines to 48 Guenter Roeck
2020-01-23 5:25 ` [PATCH v3 3/8] hw/arm/exynos4210: Fix DMA initialization Guenter Roeck
2020-01-23 5:25 ` [PATCH v3 4/8] hw/char/exynos4210_uart: Convert to support tracing Guenter Roeck
2020-01-23 5:25 ` [PATCH v3 5/8] hw/char/exynos4210_uart: Implement post_load function Guenter Roeck
2020-01-23 5:25 ` [PATCH v3 6/8] hw/char/exynos4210_uart: Implement Rx FIFO level triggers and timeouts Guenter Roeck
2020-01-23 5:25 ` [PATCH v3 7/8] hw/char/exynos4210_uart: Add receive DMA support Guenter Roeck
2020-01-23 5:25 ` [PATCH v3 8/8] hw/arm/exynos4210: Connect serial port DMA busy signals with pl330 Guenter Roeck
2020-01-23 15:20 ` [PATCH v3 0/8] Fix Exynos4210 DMA support Peter Maydell
2020-01-23 15:39 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123165720.GA4805@roeck-us.net \
--to=linux@roeck-us.net \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).