From: Stefan Hajnoczi <stefanha@redhat.com>
To: salvador@qindel.com
Cc: qemu-trivial@nongnu.org, sfandino@yahoo.com,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, stefanha@gmail.com
Subject: Re: [PATCH] qemu_set_log_filename: filename argument may be NULL
Date: Fri, 24 Jan 2020 10:24:47 +0000 [thread overview]
Message-ID: <20200124102447.GC736986@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200123193626.19956-1-salvador@qindel.com>
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On Thu, Jan 23, 2020 at 08:36:26PM +0100, salvador@qindel.com wrote:
> From: Salvador Fandino <salvador@qindel.com>
>
> NULL is a valid log filename used to indicate we want to use stderr
> but qemu_set_log_filename (which is called by bsd-user/main.c) was not
> handling it correctly.
>
> That also made redundant a couple of NULL checks in calling code which
> have been removed.
>
> Signed-off-by: Salvador Fandino <salvador@qindel.com>
> ---
> trace/control.c | 4 +---
> util/log.c | 28 ++++++++++++++++------------
> vl.c | 5 +----
> 3 files changed, 18 insertions(+), 19 deletions(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-24 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 21:08 [PATCH] qemu_set_log_filename: filename argument may be NULL salvador
2020-01-23 11:32 ` Stefan Hajnoczi
2020-01-23 19:36 ` salvador
2020-01-24 10:23 ` Stefan Hajnoczi
2020-01-24 10:24 ` Stefan Hajnoczi [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-22 20:21 salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124102447.GC736986@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=salvador@qindel.com \
--cc=sfandino@yahoo.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).