* [PATCH v2] s390x: sigp: Fix sense running reporting
@ 2020-01-24 13:48 Janosch Frank
2020-01-24 15:00 ` Cornelia Huck
0 siblings, 1 reply; 2+ messages in thread
From: Janosch Frank @ 2020-01-24 13:48 UTC (permalink / raw)
To: qemu-devel; +Cc: borntraeger, thuth, cohuck, qemu-s390x, david
The logic was inverted and reported running if the cpu was stopped.
Let's fix that.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Fixes: d1b468bc8869 ("s390x/tcg: implement SIGP SENSE RUNNING STATUS")
Reviewed-by: David Hildenbrand <david@redhat.com>
---
Switched the actions instead of the condition so the comment still
applies.
---
target/s390x/sigp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c
index 727875bb4a..c604f17710 100644
--- a/target/s390x/sigp.c
+++ b/target/s390x/sigp.c
@@ -348,9 +348,9 @@ static void sigp_sense_running(S390CPU *dst_cpu, SigpInfo *si)
/* If halted (which includes also STOPPED), it is not running */
if (CPU(dst_cpu)->halted) {
- si->cc = SIGP_CC_ORDER_CODE_ACCEPTED;
- } else {
set_sigp_status(si, SIGP_STAT_NOT_RUNNING);
+ } else {
+ si->cc = SIGP_CC_ORDER_CODE_ACCEPTED;
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] s390x: sigp: Fix sense running reporting
2020-01-24 13:48 [PATCH v2] s390x: sigp: Fix sense running reporting Janosch Frank
@ 2020-01-24 15:00 ` Cornelia Huck
0 siblings, 0 replies; 2+ messages in thread
From: Cornelia Huck @ 2020-01-24 15:00 UTC (permalink / raw)
To: Janosch Frank; +Cc: qemu-s390x, borntraeger, thuth, qemu-devel, david
On Fri, 24 Jan 2020 08:48:18 -0500
Janosch Frank <frankja@linux.ibm.com> wrote:
> The logic was inverted and reported running if the cpu was stopped.
> Let's fix that.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Fixes: d1b468bc8869 ("s390x/tcg: implement SIGP SENSE RUNNING STATUS")
> Reviewed-by: David Hildenbrand <david@redhat.com>
> ---
>
> Switched the actions instead of the condition so the comment still
> applies.
>
> ---
> target/s390x/sigp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-24 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-24 13:48 [PATCH v2] s390x: sigp: Fix sense running reporting Janosch Frank
2020-01-24 15:00 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).