From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC31C2D0DB for ; Fri, 24 Jan 2020 14:25:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDC092075D for ; Fri, 24 Jan 2020 14:25:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MpQNHRIN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDC092075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43037 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuzuI-0005Pv-2N for qemu-devel@archiver.kernel.org; Fri, 24 Jan 2020 09:25:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43093) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuztd-0004sk-Gy for qemu-devel@nongnu.org; Fri, 24 Jan 2020 09:25:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuztc-0004IX-Ih for qemu-devel@nongnu.org; Fri, 24 Jan 2020 09:25:17 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:34768 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuztc-0004Hn-F6 for qemu-devel@nongnu.org; Fri, 24 Jan 2020 09:25:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579875916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c54fuVG0vxmx0kRXePeuvFU3Nt/3abqmiRwp/hdBskU=; b=MpQNHRINypTSFwu3fXVnhPxqcar6498rr1gM3HGW2Sk9DBZ1QKq1BO24WzYyVXoOwJUAFw S38zdtYYkNvkDONauUfgMjYJE9kMTnrTRLO/gOGrFbxnno1Nnm2YXWvrmFKKKI25EcUjyb Sh2wAI1cVv9Lxx7hoAWdMlKelF7nmBU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-355-6OkJXfmHNsqLCzykMh3hJA-1; Fri, 24 Jan 2020 09:25:14 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EFFCE1088383; Fri, 24 Jan 2020 14:25:12 +0000 (UTC) Received: from gondolin (dhcp-192-195.str.redhat.com [10.33.192.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1143F1001B05; Fri, 24 Jan 2020 14:25:11 +0000 (UTC) Date: Fri, 24 Jan 2020 15:25:09 +0100 From: Cornelia Huck To: Thomas Huth Subject: Re: [PATCH 0/5] target/s390x: Do not leak stack address in translate_one Message-ID: <20200124152509.0de4137e.cohuck@redhat.com> In-Reply-To: <41ea3b7b-745d-4d8a-24fa-3862035db41d@redhat.com> References: <20200123232248.1800-1-richard.henderson@linaro.org> <41ea3b7b-745d-4d8a-24fa-3862035db41d@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: 6OkJXfmHNsqLCzykMh3hJA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Richard Henderson , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 24 Jan 2020 10:43:32 +0100 Thomas Huth wrote: > On 24/01/2020 00.22, Richard Henderson wrote: > > Thomas' patch avoids the leak, but I think we can do a bit more to > > cleaning in this area, and move the structure inline to DisasContext. > > > Sounds like a good idea to me. Cornelia, could you please replace my > patch with Richard's series? Yes, that sounds good. Dropped your patch in favour of this series.