From: Cornelia Huck <cohuck@redhat.com>
To: Collin Walling <walling@linux.ibm.com>
Cc: borntraeger@de.ibm.com, qemu-s390x@nongnu.org, david@redhat.com,
qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [PATCH v6 2/2] s390: diagnose 318 info reset and migration support
Date: Tue, 28 Jan 2020 16:08:09 +0100 [thread overview]
Message-ID: <20200128160809.2b5bec10.cohuck@redhat.com> (raw)
In-Reply-To: <4c7cfd8f-3994-404e-1587-293e19f471de@linux.ibm.com>
On Tue, 28 Jan 2020 09:37:46 -0500
Collin Walling <walling@linux.ibm.com> wrote:
> On 1/27/20 12:35 PM, Cornelia Huck wrote:
> > On Mon, 27 Jan 2020 11:39:02 -0500
> > Collin Walling <walling@linux.ibm.com> wrote:
> >
> >> On 1/27/20 6:47 AM, Cornelia Huck wrote:
> >>> On Fri, 24 Jan 2020 17:14:04 -0500
> >>> Collin Walling <walling@linux.ibm.com> wrote:
> >>>
> >>>> DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must
> >>>> be intercepted by SIE and handled via KVM. Let's introduce some
> >>>> functions to communicate between QEMU and KVM via ioctls. These
> >>>> will be used to get/set the diag318 information.
> >>>
> >>> Do you want to give a hint what diag 318 actually does?
> >>>
> >>
> >> For the sake of completeness, I'll have to get back to you on this.
> >>
>
> The DIAGNOSE 318 instruction allows the guest to store diagnostic data
> that is collected by the firmware in the case of hardware/firmware
> service events. The instruction is invoked in the Linux kernel and
> intercepted in KVM. QEMU needs to collect this data for migration
> so that this data is consistent on the destination host.
>
> Perhaps I should add this to the patch description as well? :)
Yes, please :) It will make things easier for any unfortunate soul
wanting to find out what this is about in the future.
next prev parent reply other threads:[~2020-01-28 15:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 22:14 [PATCH v6 0/2] Use DIAG318 to set Control Program Name & Version Codes Collin Walling
2020-01-24 22:14 ` [PATCH v6 1/2] s390/kvm: header sync for diag318 Collin Walling
2020-01-24 22:14 ` [PATCH v6 2/2] s390: diagnose 318 info reset and migration support Collin Walling
2020-01-27 11:20 ` David Hildenbrand
2020-01-27 15:57 ` Collin Walling
2020-01-27 17:09 ` David Hildenbrand
2020-01-27 17:29 ` Cornelia Huck
2020-01-27 17:55 ` David Hildenbrand
2020-01-27 18:21 ` Collin Walling
2020-01-27 18:52 ` Collin Walling
2020-01-28 11:19 ` Cornelia Huck
2020-01-27 11:36 ` Thomas Huth
2020-01-27 15:58 ` Collin Walling
2020-01-27 11:47 ` Cornelia Huck
2020-01-27 16:39 ` Collin Walling
2020-01-27 17:35 ` Cornelia Huck
2020-01-27 23:05 ` Collin Walling
2020-01-28 11:24 ` Cornelia Huck
2020-01-28 14:38 ` Collin Walling
2020-01-28 14:37 ` Collin Walling
2020-01-28 15:08 ` Cornelia Huck [this message]
2020-01-24 22:22 ` [PATCH v6 0/2] Use DIAG318 to set Control Program Name & Version Codes no-reply
2020-03-17 21:34 ` Collin Walling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128160809.2b5bec10.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).