Re: [PATCH v3 07/18] machine: Add a new function init_apicid_fn in MachineClass

[Igor Mammedov <imammedo@redhat.com>]

On Tue, 03 Dec 2019 18:37:42 -0600
Babu Moger <babu.moger@amd.com> wrote:

> Add a new function init_apicid_fn in MachineClass to initialize the mode
> specific handlers to decode the apic ids.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
>  include/hw/boards.h |    1 +
>  vl.c                |    3 +++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index d4fab218e6..ce5aa365cb 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -238,6 +238,7 @@ struct MachineClass {
>                                                           unsigned cpu_index);
>      const CPUArchIdList *(*possible_cpu_arch_ids)(MachineState *machine);
>      int64_t (*get_default_cpu_node_id)(const MachineState *ms, int idx);
> +    void (*init_apicid_fn)(MachineState *ms);
it's x86 specific, so why it wasn put into PCMachineClass?


>  };
>  
>  /**
> diff --git a/vl.c b/vl.c
> index a42c24a77f..b6af604e11 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4318,6 +4318,9 @@ int main(int argc, char **argv, char **envp)
>      current_machine->cpu_type = machine_class->default_cpu_type;
>      if (cpu_option) {
>          current_machine->cpu_type = parse_cpu_option(cpu_option);
> +        if (machine_class->init_apicid_fn) {
> +            machine_class->init_apicid_fn(current_machine);
> +        }
>      }
>      parse_numa_opts(current_machine);
>  
> 
>