From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D94CAC33CB2 for ; Tue, 28 Jan 2020 19:40:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A761A206A2 for ; Tue, 28 Jan 2020 19:40:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gUoPZsIj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A761A206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwWir-0002NE-Rn for qemu-devel@archiver.kernel.org; Tue, 28 Jan 2020 14:40:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36419) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwVOk-0001Gr-Tz for qemu-devel@nongnu.org; Tue, 28 Jan 2020 13:15:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwVOj-0001BZ-7v for qemu-devel@nongnu.org; Tue, 28 Jan 2020 13:15:38 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:31156 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iwVOi-0001A2-Tw for qemu-devel@nongnu.org; Tue, 28 Jan 2020 13:15:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580235336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vB8bRgsl1wOabwuyBJiR1sNWzMD1CYoWuLVu6A4rM9c=; b=gUoPZsIjBALmJK06NyL+u4OanawvPgsTLUNVACS0ZkX7jpuOxj5GCgFVFoxH4IKYa2wt0A UqXKGUZcbJ4m6eI+qoUPT6SoE8UTjf4oeOz+Ls3B2bairgv1dh/WulPgGABJca71nhTMTa 32fjX3TGv+9LrtREv0s7/7U08qafBZ4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412-uhcXm0t3On2qOGIR-_3iNQ-1; Tue, 28 Jan 2020 13:15:34 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8A80C477; Tue, 28 Jan 2020 18:15:33 +0000 (UTC) Received: from work-vm (unknown [10.36.118.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 96B96845C5; Tue, 28 Jan 2020 18:15:29 +0000 (UTC) Date: Tue, 28 Jan 2020 18:15:27 +0000 From: "Dr. David Alan Gilbert" To: Maxim Levitsky Subject: Re: [PATCH v3 06/13] monitor/hmp: move hmp_block_job* to block-hmp-cmds.c Message-ID: <20200128181527.GZ3215@work-vm> References: <20200127103647.17761-1-mlevitsk@redhat.com> <20200127103647.17761-7-mlevitsk@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200127103647.17761-7-mlevitsk@redhat.com> User-Agent: Mutt/1.13.3 (2020-01-12) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: uhcXm0t3On2qOGIR-_3iNQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, Max Reitz , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Maxim Levitsky (mlevitsk@redhat.com) wrote: > Signed-off-by: Maxim Levitsky Reviewed-by: Dr. David Alan Gilbert > --- > block/monitor/block-hmp-cmds.c | 52 ++++++++++++++++++++++++++++++ > include/block/block-hmp-commands.h | 6 ++++ > include/monitor/hmp.h | 5 --- > monitor/hmp-cmds.c | 52 ------------------------------ > 4 files changed, 58 insertions(+), 57 deletions(-) >=20 > diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmd= s.c > index ae3890aaab..ed3c350143 100644 > --- a/block/monitor/block-hmp-cmds.c > +++ b/block/monitor/block-hmp-cmds.c > @@ -228,3 +228,55 @@ void hmp_drive_backup(Monitor *mon, const QDict *qdi= ct) > qmp_drive_backup(&backup, &err); > hmp_handle_error(mon, err); > } > + > +void hmp_block_job_set_speed(Monitor *mon, const QDict *qdict) > +{ > + Error *error =3D NULL; > + const char *device =3D qdict_get_str(qdict, "device"); > + int64_t value =3D qdict_get_int(qdict, "speed"); > + > + qmp_block_job_set_speed(device, value, &error); > + > + hmp_handle_error(mon, error); > +} > + > +void hmp_block_job_cancel(Monitor *mon, const QDict *qdict) > +{ > + Error *error =3D NULL; > + const char *device =3D qdict_get_str(qdict, "device"); > + bool force =3D qdict_get_try_bool(qdict, "force", false); > + > + qmp_block_job_cancel(device, true, force, &error); > + > + hmp_handle_error(mon, error); > +} > + > +void hmp_block_job_pause(Monitor *mon, const QDict *qdict) > +{ > + Error *error =3D NULL; > + const char *device =3D qdict_get_str(qdict, "device"); > + > + qmp_block_job_pause(device, &error); > + > + hmp_handle_error(mon, error); > +} > + > +void hmp_block_job_resume(Monitor *mon, const QDict *qdict) > +{ > + Error *error =3D NULL; > + const char *device =3D qdict_get_str(qdict, "device"); > + > + qmp_block_job_resume(device, &error); > + > + hmp_handle_error(mon, error); > +} > + > +void hmp_block_job_complete(Monitor *mon, const QDict *qdict) > +{ > + Error *error =3D NULL; > + const char *device =3D qdict_get_str(qdict, "device"); > + > + qmp_block_job_complete(device, &error); > + > + hmp_handle_error(mon, error); > +} > diff --git a/include/block/block-hmp-commands.h b/include/block/block-hmp= -commands.h > index fcaf753118..ea6578a5f6 100644 > --- a/include/block/block-hmp-commands.h > +++ b/include/block/block-hmp-commands.h > @@ -11,4 +11,10 @@ void hmp_drive_del(Monitor *mon, const QDict *qdict); > void hmp_drive_mirror(Monitor *mon, const QDict *qdict); > void hmp_drive_backup(Monitor *mon, const QDict *qdict); > =20 > +void hmp_block_job_set_speed(Monitor *mon, const QDict *qdict); > +void hmp_block_job_cancel(Monitor *mon, const QDict *qdict); > +void hmp_block_job_pause(Monitor *mon, const QDict *qdict); > +void hmp_block_job_resume(Monitor *mon, const QDict *qdict); > +void hmp_block_job_complete(Monitor *mon, const QDict *qdict); > + > #endif > diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h > index c1b363ee57..592ce0ccfe 100644 > --- a/include/monitor/hmp.h > +++ b/include/monitor/hmp.h > @@ -87,11 +87,6 @@ void hmp_eject(Monitor *mon, const QDict *qdict); > void hmp_change(Monitor *mon, const QDict *qdict); > void hmp_block_set_io_throttle(Monitor *mon, const QDict *qdict); > void hmp_block_stream(Monitor *mon, const QDict *qdict); > -void hmp_block_job_set_speed(Monitor *mon, const QDict *qdict); > -void hmp_block_job_cancel(Monitor *mon, const QDict *qdict); > -void hmp_block_job_pause(Monitor *mon, const QDict *qdict); > -void hmp_block_job_resume(Monitor *mon, const QDict *qdict); > -void hmp_block_job_complete(Monitor *mon, const QDict *qdict); > void hmp_migrate(Monitor *mon, const QDict *qdict); > void hmp_device_add(Monitor *mon, const QDict *qdict); > void hmp_device_del(Monitor *mon, const QDict *qdict); > diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > index a70bcb1d16..996ce96430 100644 > --- a/monitor/hmp-cmds.c > +++ b/monitor/hmp-cmds.c > @@ -1975,58 +1975,6 @@ void hmp_block_stream(Monitor *mon, const QDict *q= dict) > hmp_handle_error(mon, error); > } > =20 > -void hmp_block_job_set_speed(Monitor *mon, const QDict *qdict) > -{ > - Error *error =3D NULL; > - const char *device =3D qdict_get_str(qdict, "device"); > - int64_t value =3D qdict_get_int(qdict, "speed"); > - > - qmp_block_job_set_speed(device, value, &error); > - > - hmp_handle_error(mon, error); > -} > - > -void hmp_block_job_cancel(Monitor *mon, const QDict *qdict) > -{ > - Error *error =3D NULL; > - const char *device =3D qdict_get_str(qdict, "device"); > - bool force =3D qdict_get_try_bool(qdict, "force", false); > - > - qmp_block_job_cancel(device, true, force, &error); > - > - hmp_handle_error(mon, error); > -} > - > -void hmp_block_job_pause(Monitor *mon, const QDict *qdict) > -{ > - Error *error =3D NULL; > - const char *device =3D qdict_get_str(qdict, "device"); > - > - qmp_block_job_pause(device, &error); > - > - hmp_handle_error(mon, error); > -} > - > -void hmp_block_job_resume(Monitor *mon, const QDict *qdict) > -{ > - Error *error =3D NULL; > - const char *device =3D qdict_get_str(qdict, "device"); > - > - qmp_block_job_resume(device, &error); > - > - hmp_handle_error(mon, error); > -} > - > -void hmp_block_job_complete(Monitor *mon, const QDict *qdict) > -{ > - Error *error =3D NULL; > - const char *device =3D qdict_get_str(qdict, "device"); > - > - qmp_block_job_complete(device, &error); > - > - hmp_handle_error(mon, error); > -} > - > typedef struct HMPMigrationStatus > { > QEMUTimer *timer; > --=20 > 2.17.2 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK