* [PATCH] iotests: Remove the superfluous 2nd check for the availability of quorum
@ 2020-01-29 14:17 Thomas Huth
2020-01-29 14:27 ` Alberto Garcia
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2020-01-29 14:17 UTC (permalink / raw)
To: qemu-devel, Max Reitz, Kevin Wolf
Cc: Andrey Shinkevich, Alberto Garcia, qemu-block
Commit d9df28e7b07 ("iotests: check whitelisted formats") added the
modern @iotests.skip_if_unsupported() to the functions in this test,
so we don't need the old explicit test here anymore.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qemu-iotests/139 | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tests/qemu-iotests/139 b/tests/qemu-iotests/139
index cbb5a76530..2f075888ba 100755
--- a/tests/qemu-iotests/139
+++ b/tests/qemu-iotests/139
@@ -344,9 +344,6 @@ class TestBlockdevDel(iotests.QMPTestCase):
@iotests.skip_if_unsupported(['quorum'])
def testQuorum(self):
- if not iotests.supports_quorum():
- return
-
self.addQuorum('quorum0', 'node0', 'node1')
# We cannot remove the children of a Quorum device
self.delBlockDriverState('node0', expect_error = True)
--
2.18.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iotests: Remove the superfluous 2nd check for the availability of quorum
2020-01-29 14:17 [PATCH] iotests: Remove the superfluous 2nd check for the availability of quorum Thomas Huth
@ 2020-01-29 14:27 ` Alberto Garcia
2020-01-31 12:17 ` Andrey Shinkevich
2020-02-06 13:54 ` Max Reitz
2 siblings, 0 replies; 4+ messages in thread
From: Alberto Garcia @ 2020-01-29 14:27 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Max Reitz, Kevin Wolf
Cc: Andrey Shinkevich, qemu-block
On Wed 29 Jan 2020 03:17:51 PM CET, Thomas Huth wrote:
> Commit d9df28e7b07 ("iotests: check whitelisted formats") added the
> modern @iotests.skip_if_unsupported() to the functions in this test,
> so we don't need the old explicit test here anymore.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iotests: Remove the superfluous 2nd check for the availability of quorum
2020-01-29 14:17 [PATCH] iotests: Remove the superfluous 2nd check for the availability of quorum Thomas Huth
2020-01-29 14:27 ` Alberto Garcia
@ 2020-01-31 12:17 ` Andrey Shinkevich
2020-02-06 13:54 ` Max Reitz
2 siblings, 0 replies; 4+ messages in thread
From: Andrey Shinkevich @ 2020-01-31 12:17 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Max Reitz, Kevin Wolf; +Cc: Alberto Garcia, qemu-block
On 29/01/2020 17:17, Thomas Huth wrote:
> Commit d9df28e7b07 ("iotests: check whitelisted formats") added the
> modern @iotests.skip_if_unsupported() to the functions in this test,
> so we don't need the old explicit test here anymore.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/139 | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/139 b/tests/qemu-iotests/139
> index cbb5a76530..2f075888ba 100755
> --- a/tests/qemu-iotests/139
> +++ b/tests/qemu-iotests/139
> @@ -344,9 +344,6 @@ class TestBlockdevDel(iotests.QMPTestCase):
>
> @iotests.skip_if_unsupported(['quorum'])
> def testQuorum(self):
> - if not iotests.supports_quorum():
> - return
> -
> self.addQuorum('quorum0', 'node0', 'node1')
> # We cannot remove the children of a Quorum device
> self.delBlockDriverState('node0', expect_error = True)
>
Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Tested-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
--
With the best regards,
Andrey Shinkevich
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iotests: Remove the superfluous 2nd check for the availability of quorum
2020-01-29 14:17 [PATCH] iotests: Remove the superfluous 2nd check for the availability of quorum Thomas Huth
2020-01-29 14:27 ` Alberto Garcia
2020-01-31 12:17 ` Andrey Shinkevich
@ 2020-02-06 13:54 ` Max Reitz
2 siblings, 0 replies; 4+ messages in thread
From: Max Reitz @ 2020-02-06 13:54 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Kevin Wolf
Cc: Andrey Shinkevich, Alberto Garcia, qemu-block
[-- Attachment #1.1: Type: text/plain, Size: 477 bytes --]
On 29.01.20 15:17, Thomas Huth wrote:
> Commit d9df28e7b07 ("iotests: check whitelisted formats") added the
> modern @iotests.skip_if_unsupported() to the functions in this test,
> so we don't need the old explicit test here anymore.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/139 | 3 ---
> 1 file changed, 3 deletions(-)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-06 13:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-29 14:17 [PATCH] iotests: Remove the superfluous 2nd check for the availability of quorum Thomas Huth
2020-01-29 14:27 ` Alberto Garcia
2020-01-31 12:17 ` Andrey Shinkevich
2020-02-06 13:54 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).