From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v3 2/4] qapi: Create module 'control'
Date: Wed, 29 Jan 2020 17:58:10 +0100 [thread overview]
Message-ID: <20200129165810.GD5690@linux.fritz.box> (raw)
In-Reply-To: <871rri2pb6.fsf@dusky.pond.sub.org>
Am 29.01.2020 um 17:35 hat Markus Armbruster geschrieben:
> Kevin Wolf <kwolf@redhat.com> writes:
>
> > misc.json contains definitions that are related to the system emulator,
> > so it can't be used for other tools like the storage daemon. This patch
> > moves basic functionality that is shared between all tools (and mostly
> > related to the monitor itself) into a new control.json, which could be
> > used in tools as well.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> I'd like to retitle this patch and the next one:
>
> qapi: Split control.json off misc.json
> monitor: Collect "control" command handlers in qmp-cmds.control.c
>
> Okay?
Sure, why not.
Kevin
next prev parent reply other threads:[~2020-01-29 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 10:22 [PATCH v3 0/4] monitor: Refactoring in preparation for qemu-storage-daemon Kevin Wolf
2020-01-29 10:22 ` [PATCH v3 1/4] monitor: Move monitor option parsing to monitor/monitor.c Kevin Wolf
2020-01-29 10:22 ` [PATCH v3 2/4] qapi: Create module 'control' Kevin Wolf
2020-01-29 16:35 ` Markus Armbruster
2020-01-29 16:58 ` Kevin Wolf [this message]
2020-01-30 7:31 ` Markus Armbruster
2020-01-29 10:22 ` [PATCH v3 3/4] monitor: Create monitor/qmp-cmds-control.c Kevin Wolf
2020-01-29 10:22 ` [PATCH v3 4/4] monitor: Move qmp_query_qmp_schema to qmp-cmds-control.c Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129165810.GD5690@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).