From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: hsp.cat7@gmail.com, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Subject: [PATCH 3/4] target/ppc: Remove redundant mask in DCBZ
Date: Wed, 29 Jan 2020 15:50:39 -0800 [thread overview]
Message-ID: <20200129235040.24022-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20200129235040.24022-1-richard.henderson@linaro.org>
The value of addr has already been masked, just above.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/ppc/mem_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c
index e7d3a79d96..0cb78777e7 100644
--- a/target/ppc/mem_helper.c
+++ b/target/ppc/mem_helper.c
@@ -293,7 +293,7 @@ static void dcbz_common(CPUPPCState *env, target_ulong addr,
addr &= mask;
/* Check reservation */
- if ((env->reserve_addr & mask) == (addr & mask)) {
+ if ((env->reserve_addr & mask) == addr) {
env->reserve_addr = (target_ulong)-1ULL;
}
--
2.20.1
next prev parent reply other threads:[~2020-01-29 23:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 23:50 [PATCH 0/4] target/ppc: Use probe_access Richard Henderson
2020-01-29 23:50 ` [PATCH 1/4] target/ppc: Use probe_access for LSW, STSW Richard Henderson
2020-01-29 23:50 ` [PATCH 2/4] target/ppc: Use probe_access for LMW, STMW Richard Henderson
2020-01-29 23:50 ` Richard Henderson [this message]
2020-01-29 23:50 ` [PATCH 4/4] target/ppc: Use probe_write for DCBZ Richard Henderson
2020-01-30 1:35 ` [PATCH 0/4] target/ppc: Use probe_access Aleksandar Markovic
2020-01-30 16:09 ` Richard Henderson
2020-01-30 16:42 ` Aleksandar Markovic
2020-01-30 7:08 ` Howard Spoelstra
2020-01-30 15:09 ` Howard Spoelstra
2020-01-30 16:07 ` Aleksandar Markovic
2020-01-30 23:54 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129235040.24022-4-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=hsp.cat7@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).