From: "Michael S. Tsirkin" <mst@redhat.com>
To: Heyi Guo <guoheyi@huawei.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Shannon Zhao <shannon.zhaosl@gmail.com>,
qemu-arm@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
wanghaibin.wang@huawei.com
Subject: Re: [PATCH v2 3/7] arm/virt/acpi: remove _ADR from devices identified by _HID
Date: Mon, 3 Feb 2020 00:33:08 -0500 [thread overview]
Message-ID: <20200203003301-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200203001505.52573-4-guoheyi@huawei.com>
On Mon, Feb 03, 2020 at 08:15:01AM +0800, Heyi Guo wrote:
> According to ACPI spec, _ADR should be used for device on a bus that
> has a standard enumeration algorithm, but not for device which is on
> system bus and must be enumerated by OSPM. And it is not recommended
> to contain both _HID and _ADR in a single device.
>
> See ACPI 6.3, section 6.1, top of page 343:
>
> A device object must contain either an _HID object or an _ADR object,
> but should not contain both.
>
> (https://uefi.org/sites/default/files/resources/ACPI_6_3_May16.pdf)
>
> Signed-off-by: Heyi Guo <guoheyi@huawei.com>
> Acked-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> Cc: Shannon Zhao <shannon.zhaosl@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: qemu-arm@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
> hw/arm/virt-acpi-build.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index 9f4c7d1889..be752c0ad8 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -78,11 +78,6 @@ static void acpi_dsdt_add_uart(Aml *scope, const MemMapEntry *uart_memmap,
> AML_EXCLUSIVE, &uart_irq, 1));
> aml_append(dev, aml_name_decl("_CRS", crs));
>
> - /* The _ADR entry is used to link this device to the UART described
> - * in the SPCR table, i.e. SPCR.base_address.address == _ADR.
> - */
> - aml_append(dev, aml_name_decl("_ADR", aml_int(uart_memmap->base)));
> -
> aml_append(scope, dev);
> }
>
> @@ -170,7 +165,6 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
> aml_append(dev, aml_name_decl("_CID", aml_string("PNP0A03")));
> aml_append(dev, aml_name_decl("_SEG", aml_int(0)));
> aml_append(dev, aml_name_decl("_BBN", aml_int(0)));
> - aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
> aml_append(dev, aml_name_decl("_UID", aml_string("PCI0")));
> aml_append(dev, aml_name_decl("_STR", aml_unicode("PCIe 0 Device")));
> aml_append(dev, aml_name_decl("_CCA", aml_int(1)));
> @@ -334,7 +328,6 @@ static void acpi_dsdt_add_gpio(Aml *scope, const MemMapEntry *gpio_memmap,
> {
> Aml *dev = aml_device("GPO0");
> aml_append(dev, aml_name_decl("_HID", aml_string("ARMH0061")));
> - aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
> aml_append(dev, aml_name_decl("_UID", aml_int(0)));
>
> Aml *crs = aml_resource_template();
> @@ -364,7 +357,6 @@ static void acpi_dsdt_add_power_button(Aml *scope)
> {
> Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE);
> aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C")));
> - aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
> aml_append(dev, aml_name_decl("_UID", aml_int(0)));
> aml_append(scope, dev);
> }
> --
> 2.19.1
next prev parent reply other threads:[~2020-02-03 5:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 0:14 [PATCH v2 0/7] Some cleanup in arm/virt/acpi Heyi Guo
2020-02-03 0:14 ` [PATCH v2 1/7] bios-tables-test: prepare to change ARM virt ACPI DSDT Heyi Guo
2020-02-03 5:33 ` Michael S. Tsirkin
2020-02-03 0:15 ` [PATCH v2 2/7] arm/virt/acpi: remove meaningless sub device "RP0" from PCI0 Heyi Guo
2020-02-03 0:15 ` [PATCH v2 3/7] arm/virt/acpi: remove _ADR from devices identified by _HID Heyi Guo
2020-02-03 5:33 ` Michael S. Tsirkin [this message]
2020-02-03 0:15 ` [PATCH v2 4/7] arm/acpi: fix PCI _PRT definition Heyi Guo
2020-02-03 6:10 ` Michael S. Tsirkin
2020-02-03 0:15 ` [PATCH v2 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devices Heyi Guo
2020-02-03 5:59 ` Michael S. Tsirkin
2020-02-03 0:15 ` [PATCH v2 6/7] arm/acpi: simplify the description of PCI _CRS Heyi Guo
2020-02-03 6:00 ` Michael S. Tsirkin
2020-02-03 0:15 ` [PATCH v2 7/7] virt/acpi: update golden masters for DSDT update Heyi Guo
2020-02-03 5:34 ` Michael S. Tsirkin
2020-02-03 6:43 ` [PATCH v2 0/7] Some cleanup in arm/virt/acpi Michael S. Tsirkin
2020-02-03 13:33 ` Heyi Guo
2020-02-03 14:03 ` Peter Maydell
2020-02-04 1:43 ` Heyi Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203003301-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=guoheyi@huawei.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=wanghaibin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).