From: "Michael S. Tsirkin" <mst@redhat.com>
To: Heyi Guo <guoheyi@huawei.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Shannon Zhao <shannon.zhaosl@gmail.com>,
qemu-arm@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
wanghaibin.wang@huawei.com
Subject: Re: [PATCH v2 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devices
Date: Mon, 3 Feb 2020 00:59:01 -0500 [thread overview]
Message-ID: <20200203005841-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200203001505.52573-6-guoheyi@huawei.com>
On Mon, Feb 03, 2020 at 08:15:03AM +0800, Heyi Guo wrote:
> Using _UID of 0 for all PCI interrupt link devices absolutely violates
> the spec. Simply increase one by one.
>
> Signed-off-by: Heyi Guo <guoheyi@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Shannon Zhao <shannon.zhaosl@gmail.com>
> Cc: qemu-arm@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
> hw/arm/virt-acpi-build.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index 5d157a9dd5..f3e340b172 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -189,7 +189,7 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
> uint32_t irqs = irq + i;
> Aml *dev_gsi = aml_device("GSI%d", i);
> aml_append(dev_gsi, aml_name_decl("_HID", aml_string("PNP0C0F")));
> - aml_append(dev_gsi, aml_name_decl("_UID", aml_int(0)));
> + aml_append(dev_gsi, aml_name_decl("_UID", aml_int(i)));
> crs = aml_resource_template();
> aml_append(crs,
> aml_interrupt(AML_CONSUMER, AML_LEVEL, AML_ACTIVE_HIGH,
> --
> 2.19.1
next prev parent reply other threads:[~2020-02-03 5:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 0:14 [PATCH v2 0/7] Some cleanup in arm/virt/acpi Heyi Guo
2020-02-03 0:14 ` [PATCH v2 1/7] bios-tables-test: prepare to change ARM virt ACPI DSDT Heyi Guo
2020-02-03 5:33 ` Michael S. Tsirkin
2020-02-03 0:15 ` [PATCH v2 2/7] arm/virt/acpi: remove meaningless sub device "RP0" from PCI0 Heyi Guo
2020-02-03 0:15 ` [PATCH v2 3/7] arm/virt/acpi: remove _ADR from devices identified by _HID Heyi Guo
2020-02-03 5:33 ` Michael S. Tsirkin
2020-02-03 0:15 ` [PATCH v2 4/7] arm/acpi: fix PCI _PRT definition Heyi Guo
2020-02-03 6:10 ` Michael S. Tsirkin
2020-02-03 0:15 ` [PATCH v2 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devices Heyi Guo
2020-02-03 5:59 ` Michael S. Tsirkin [this message]
2020-02-03 0:15 ` [PATCH v2 6/7] arm/acpi: simplify the description of PCI _CRS Heyi Guo
2020-02-03 6:00 ` Michael S. Tsirkin
2020-02-03 0:15 ` [PATCH v2 7/7] virt/acpi: update golden masters for DSDT update Heyi Guo
2020-02-03 5:34 ` Michael S. Tsirkin
2020-02-03 6:43 ` [PATCH v2 0/7] Some cleanup in arm/virt/acpi Michael S. Tsirkin
2020-02-03 13:33 ` Heyi Guo
2020-02-03 14:03 ` Peter Maydell
2020-02-04 1:43 ` Heyi Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203005841-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=guoheyi@huawei.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=wanghaibin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).