Re: [PATCH v2 6/7] arm/acpi: simplify the description of PCI _CRS

["Michael S. Tsirkin" <mst@redhat.com>]

On Mon, Feb 03, 2020 at 08:15:04AM +0800, Heyi Guo wrote:
> The original code defines a named object for the resource template but
> then returns the resource template object itself; the resulted output
> is like below:
> 
> Method (_CRS, 0, NotSerialized)  // _CRS: Current Resource Settings
> {
>     Name (RBUF, ResourceTemplate ()
>     {
>         WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
>             0x0000,             // Granularity
>             0x0000,             // Range Minimum
>             0x00FF,             // Range Maximum
>             0x0000,             // Translation Offset
>             0x0100,             // Length
>             ,, )
>         ......
>     })
>     Return (ResourceTemplate ()
>     {
>         WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
>             0x0000,             // Granularity
>             0x0000,             // Range Minimum
>             0x00FF,             // Range Maximum
>             0x0000,             // Translation Offset
>             0x0100,             // Length
>             ,, )
>         ......
>     })
> }
> 
> So the named object "RBUF" is actually useless. The more natural way
> is to return RBUF instead, or simply drop RBUF definition.
> 
> Choose the latter one to simplify the code.
> 
> Signed-off-by: Heyi Guo <guoheyi@huawei.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Shannon Zhao <shannon.zhaosl@gmail.com>
> Cc: qemu-arm@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
>  hw/arm/virt-acpi-build.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index f3e340b172..fb4b166f82 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -236,7 +236,6 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap,
>                               size_mmio_high));
>      }
>  
> -    aml_append(method, aml_name_decl("RBUF", rbuf));
>      aml_append(method, aml_return(rbuf));
>      aml_append(dev, method);
>  
> -- 
> 2.19.1