qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: Miroslav Rezanina <mrezanin@redhat.com>
Subject: [PULL 01/13] test-logging: Fix -Werror=maybe-uninitialized warning
Date: Mon,  3 Feb 2020 13:37:59 +0100	[thread overview]
Message-ID: <20200203123811.8651-2-thuth@redhat.com> (raw)
In-Reply-To: <20200203123811.8651-1-thuth@redhat.com>

From: Miroslav Rezanina <mrezanin@redhat.com>

Checking for uninitialized variables raises warning for file path
variables in test_logfile_write and test_logfile_lock functions.

To suppress this warning, initialize varibles to NULL. This is safe
change as result of g_build_filename is stored to them before any usage.

Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
Message-Id: <63b0fcedf7dfe799c8210b113e5dccf32414a89d.1579598240.git.mrezanin@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Robert Foley <robert.foley@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/test-logging.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/test-logging.c b/tests/test-logging.c
index 1e646f045d..6387e4933f 100644
--- a/tests/test-logging.c
+++ b/tests/test-logging.c
@@ -114,8 +114,8 @@ static void test_logfile_write(gconstpointer data)
     QemuLogFile *logfile2;
     gchar const *dir = data;
     Error *err = NULL;
-    g_autofree gchar *file_path;
-    g_autofree gchar *file_path1;
+    g_autofree gchar *file_path = NULL;
+    g_autofree gchar *file_path1 = NULL;
     FILE *orig_fd;
 
     /*
@@ -157,7 +157,7 @@ static void test_logfile_lock(gconstpointer data)
     FILE *logfile;
     gchar const *dir = data;
     Error *err = NULL;
-    g_autofree gchar *file_path;
+    g_autofree gchar *file_path = NULL;
 
     file_path = g_build_filename(dir, "qemu_test_logfile_lock0.log", NULL);
 
-- 
2.18.1



  reply	other threads:[~2020-02-03 12:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03 12:37 [PULL 00/13] qtests, kconfig and misc patches Thomas Huth
2020-02-03 12:37 ` Thomas Huth [this message]
2020-02-03 12:38 ` [PULL 02/13] tests/vhost-user-bridge: Fix build Thomas Huth
2020-02-03 12:38 ` [PULL 03/13] docs/devel: Fix qtest paths and info about check-block in testing.rst Thomas Huth
2020-02-03 12:38 ` [PULL 04/13] tests/Makefile: Fix inclusion of the qos dependency files Thomas Huth
2020-02-03 12:38 ` [PULL 05/13] boot-order-test: fix memleaks in boot-order-test Thomas Huth
2020-02-03 12:38 ` [PULL 06/13] tests/qtest: update comments about bios-tables-test-allowed-diff.h Thomas Huth
2020-02-03 12:38 ` [PULL 07/13] gitlab-ci: Refresh the list of iotests Thomas Huth
2020-02-03 12:38 ` [PULL 08/13] hw/bt: Remove empty Kconfig file Thomas Huth
2020-02-03 12:38 ` [PULL 09/13] hw/input: Do not enable CONFIG_PCKBD by default Thomas Huth
2020-02-03 12:38 ` [PULL 10/13] hw/hppa/Kconfig: LASI chipset requires PARALLEL port Thomas Huth
2020-02-03 12:38 ` [PULL 11/13] hw/*/Makefile.objs: Move many .o files to common-objs Thomas Huth
2020-02-03 12:38 ` [PULL 12/13] include/sysemu/sysemu.h: Remove usused variable no_quit Thomas Huth
2020-02-03 12:38 ` [PULL 13/13] trivial: Remove xenfb_enabled from sysemu.h Thomas Huth
2020-02-03 14:04 ` [PULL 00/13] qtests, kconfig and misc patches Peter Maydell
2020-02-03 14:30   ` Thomas Huth
2020-02-03 14:43     ` Thomas Huth
2020-02-03 14:50     ` Peter Maydell
2020-02-03 14:57       ` Thomas Huth
2020-02-03 15:02         ` Thomas Huth
2020-02-03 15:17       ` Paolo Bonzini
2020-02-03 15:29         ` Paolo Bonzini
2020-02-03 15:38           ` Thomas Huth
2020-02-03 15:35       ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200203123811.8651-2-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=mrezanin@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).