* [PATCH] make all Python scripts executable
@ 2020-02-04 16:02 Paolo Bonzini
2020-02-04 18:18 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2020-02-04 16:02 UTC (permalink / raw)
To: qemu-devel; +Cc: Philippe Mathieu-Daudé
Scripts that have a Python shebang are meant to be executed directly from the
shell; give them 755 permissions.
Based-on: <20200204160028.16211-1-pbonzini@redhat.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
scripts/minikconf.py | 0
scripts/signrom.py | 0
tests/qemu-iotests/222 | 0
tests/qemu-iotests/245 | 0
4 files changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 scripts/minikconf.py
mode change 100644 => 100755 scripts/signrom.py
mode change 100644 => 100755 tests/qemu-iotests/222
mode change 100644 => 100755 tests/qemu-iotests/245
diff --git a/scripts/minikconf.py b/scripts/minikconf.py
old mode 100644
new mode 100755
diff --git a/scripts/signrom.py b/scripts/signrom.py
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245
old mode 100644
new mode 100755
--
2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] make all Python scripts executable
2020-02-04 16:02 [PATCH] make all Python scripts executable Paolo Bonzini
@ 2020-02-04 18:18 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-04 18:18 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 2/4/20 5:02 PM, Paolo Bonzini wrote:
> Scripts that have a Python shebang are meant to be executed directly from the
> shell; give them 755 permissions.
Ah I should have done the chmod in my "Explicit usage of Python 3
(scripts with __main__)" patches, but I would have missed
scripts/signrom.py and tests/qemu-iotests/222.
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Based-on: <20200204160028.16211-1-pbonzini@redhat.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> scripts/minikconf.py | 0
> scripts/signrom.py | 0
> tests/qemu-iotests/222 | 0
> tests/qemu-iotests/245 | 0
> 4 files changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 scripts/minikconf.py
> mode change 100644 => 100755 scripts/signrom.py
> mode change 100644 => 100755 tests/qemu-iotests/222
> mode change 100644 => 100755 tests/qemu-iotests/245
>
> diff --git a/scripts/minikconf.py b/scripts/minikconf.py
> old mode 100644
> new mode 100755
> diff --git a/scripts/signrom.py b/scripts/signrom.py
> old mode 100644
> new mode 100755
> diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
> old mode 100644
> new mode 100755
> diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245
> old mode 100644
> new mode 100755
>
Thanks, patch applied to my python-next tree:
https://gitlab.com/philmd/qemu/commits/python-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-04 18:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-04 16:02 [PATCH] make all Python scripts executable Paolo Bonzini
2020-02-04 18:18 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).