From: Darren Kenny <darren.kenny@oracle.com>
To: "Bulekov, Alexander" <alxndr@bu.edu>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"bsd@redhat.com" <bsd@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"stefanha@redhat.com" <stefanha@redhat.com>
Subject: Re: [PATCH v8 13/21] main: keep rcu_atfork callback enabled for qtest
Date: Wed, 5 Feb 2020 13:58:06 +0000 [thread overview]
Message-ID: <20200205135806.6jfluyyoejyknlyx@starbug-mbp> (raw)
In-Reply-To: <20200129053357.27454-14-alxndr@bu.edu>
On Wed, Jan 29, 2020 at 05:34:22AM +0000, Bulekov, Alexander wrote:
>The qtest-based fuzzer makes use of forking to reset-state between
>tests. Keep the callback enabled, so the call_rcu thread gets created
>within the child process.
>
>Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
>---
> vl.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/vl.c b/vl.c
>index bb77935f04..cf8e2d3ebb 100644
>--- a/vl.c
>+++ b/vl.c
>@@ -3794,7 +3794,14 @@ void qemu_init(int argc, char **argv, char **envp)
> set_memory_options(&ram_slots, &maxram_size, machine_class);
>
> os_daemonize();
>- rcu_disable_atfork();
>+
>+ /*
>+ * If QTest is enabled, keep the rcu_atfork enabled, since system processes
>+ * may be forked testing purposes (e.g. fork-server based fuzzing)
>+ */
>+ if (!qtest_enabled()) {
>+ rcu_disable_atfork();
>+ }
>
> if (pid_file && !qemu_write_pidfile(pid_file, &err)) {
> error_reportf_err(err, "cannot create PID file: ");
>--
>2.23.0
>
>
next prev parent reply other threads:[~2020-02-05 13:59 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 5:34 [PATCH v8 00/21] Add virtual device fuzzing support Bulekov, Alexander
2020-01-29 5:34 ` [PATCH v8 01/21] softmmu: split off vl.c:main() into main.c Bulekov, Alexander
2020-01-30 14:39 ` Stefan Hajnoczi
2020-01-30 15:06 ` Alex Bennée
2020-01-30 17:44 ` Alexander Bulekov
2020-01-30 18:41 ` Alex Bennée
2020-02-05 14:02 ` Darren Kenny
2020-01-29 5:34 ` [PATCH v8 02/21] module: check module wasn't already initialized Bulekov, Alexander
2020-01-29 5:34 ` [PATCH v8 03/21] fuzz: add FUZZ_TARGET module type Bulekov, Alexander
2020-02-05 11:28 ` Darren Kenny
2020-01-29 5:34 ` [PATCH v8 04/21] qtest: add qtest_server_send abstraction Bulekov, Alexander
2020-02-05 11:30 ` Darren Kenny
2020-01-29 5:34 ` [PATCH v8 05/21] libqtest: add a layer of abstraction to send/recv Bulekov, Alexander
2020-02-05 11:32 ` Darren Kenny
2020-01-29 5:34 ` [PATCH v8 06/21] libqtest: make bufwrite rely on the TransportOps Bulekov, Alexander
2020-02-05 11:36 ` Darren Kenny
2020-01-29 5:34 ` [PATCH v8 07/21] qtest: add in-process incoming command handler Bulekov, Alexander
2020-02-05 11:39 ` Darren Kenny
2020-01-29 5:34 ` [PATCH v8 08/21] libqos: rename i2c_send and i2c_recv Bulekov, Alexander
2020-02-05 11:40 ` Darren Kenny
2020-01-29 5:34 ` [PATCH v8 09/21] libqos: split qos-test and libqos makefile vars Bulekov, Alexander
2020-01-29 5:34 ` [PATCH v8 10/21] libqos: move useful qos-test funcs to qos_external Bulekov, Alexander
2020-01-29 10:03 ` Paolo Bonzini
2020-02-05 13:34 ` Darren Kenny
2020-01-29 5:34 ` [PATCH v8 11/21] fuzz: add fuzzer skeleton Bulekov, Alexander
2020-02-05 11:55 ` Darren Kenny
2020-01-29 5:34 ` [PATCH v8 12/21] exec: keep ram block across fork when using qtest Bulekov, Alexander
2020-02-05 13:00 ` Darren Kenny
2020-01-29 5:34 ` [PATCH v8 13/21] main: keep rcu_atfork callback enabled for qtest Bulekov, Alexander
2020-01-30 14:42 ` Stefan Hajnoczi
2020-01-30 17:24 ` Paolo Bonzini
2020-01-30 17:42 ` Alexander Bulekov
2020-01-30 18:14 ` Paolo Bonzini
2020-02-05 13:58 ` Darren Kenny [this message]
2020-06-18 7:34 ` Thomas Huth
2020-06-18 15:08 ` Alexander Bulekov
2020-01-29 5:34 ` [PATCH v8 14/21] fuzz: support for fork-based fuzzing Bulekov, Alexander
2020-01-29 5:34 ` [PATCH v8 15/21] fuzz: add support for qos-assisted fuzz targets Bulekov, Alexander
2020-02-05 13:18 ` Darren Kenny
2020-02-11 16:19 ` Alexander Bulekov
2020-01-29 5:34 ` [PATCH v8 16/21] fuzz: add target/fuzz makefile rules Bulekov, Alexander
2020-01-29 5:34 ` [PATCH v8 17/21] fuzz: add configure flag --enable-fuzzing Bulekov, Alexander
2020-02-05 13:19 ` Darren Kenny
2020-01-29 5:34 ` [PATCH v8 18/21] fuzz: add i440fx fuzz targets Bulekov, Alexander
2020-02-05 13:26 ` Darren Kenny
2020-02-06 14:47 ` Alexander Bulekov
2020-01-29 5:34 ` [PATCH v8 19/21] fuzz: add virtio-net fuzz target Bulekov, Alexander
2020-01-30 14:43 ` Stefan Hajnoczi
2020-02-05 13:57 ` Darren Kenny
2020-02-06 14:51 ` Alexander Bulekov
2020-01-29 5:34 ` [PATCH v8 20/21] fuzz: add virtio-scsi " Bulekov, Alexander
2020-02-05 13:31 ` Darren Kenny
2020-01-29 5:34 ` [PATCH v8 21/21] fuzz: add documentation to docs/devel/ Bulekov, Alexander
2020-02-05 13:33 ` Darren Kenny
2020-01-30 14:44 ` [PATCH v8 00/21] Add virtual device fuzzing support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205135806.6jfluyyoejyknlyx@starbug-mbp \
--to=darren.kenny@oracle.com \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).