qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: damien.hedde@greensocs.com,
	"Peter Maydell" <peter.maydell@linaro.org>,
	luis.machado@linaro.org, richard.henderson@linaro.org,
	"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
	alan.hayward@arm.com, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v6 12/22] target/arm: default SVE length to 64 bytes for linux-user
Date: Wed,  5 Feb 2020 17:10:21 +0000	[thread overview]
Message-ID: <20200205171031.22582-13-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200205171031.22582-1-alex.bennee@linaro.org>

The Linux kernel chooses the default of 64 bytes for SVE registers on
the basis that it is the largest size on known hardware that won't
grow the signal frame. We still honour the sve-max-vq property and
userspace can expand the number of lanes by calling PR_SVE_SET_VL.

This should not make any difference to SVE enabled software as the SVE
is of course vector length agnostic.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

---
v2
  - tweak zcr_el[1] instead
---
 target/arm/cpu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index f86e71a260d..e5eac981b0a 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -199,9 +199,9 @@ static void arm_cpu_reset(CPUState *s)
         /* and to the SVE instructions */
         env->cp15.cpacr_el1 = deposit64(env->cp15.cpacr_el1, 16, 2, 3);
         env->cp15.cptr_el[3] |= CPTR_EZ;
-        /* with maximum vector length */
+        /* with reasonable vector length */
         env->vfp.zcr_el[1] = cpu_isar_feature(aa64_sve, cpu) ?
-                             cpu->sve_max_vq - 1 : 0;
+            MIN(cpu->sve_max_vq - 1, 3) : 0;
         env->vfp.zcr_el[2] = env->vfp.zcr_el[1];
         env->vfp.zcr_el[3] = env->vfp.zcr_el[1];
         /*
-- 
2.20.1



  parent reply	other threads:[~2020-02-05 17:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 17:10 [PATCH v6 00/22] gdbstub refactor and SVE support Alex Bennée
2020-02-05 17:10 ` [PATCH v6 01/22] gdbstub: make GDBState static and have common init function Alex Bennée
2020-02-05 17:10 ` [PATCH v6 02/22] gdbstub: stop passing GDBState * around and use global Alex Bennée
2020-02-05 17:10 ` [PATCH v6 03/22] gdbstub: move str_buf to GDBState and use GString Alex Bennée
2020-02-05 17:10 ` [PATCH v6 04/22] gdbstub: move mem_buf to GDBState and use GByteArray Alex Bennée
2020-02-05 17:10 ` [PATCH v6 05/22] gdbstub: add helper for 128 bit registers Alex Bennée
2020-02-05 17:10 ` [PATCH v6 06/22] target/arm: use gdb_get_reg helpers Alex Bennée
2020-02-05 17:10 ` [PATCH v6 07/22] target/m68k: " Alex Bennée
2020-02-05 17:10 ` [PATCH v6 08/22] target/i386: " Alex Bennée
2020-02-06 11:14   ` Richard Henderson
2020-02-05 17:10 ` [PATCH v6 09/22] gdbstub: extend GByteArray to read register helpers Alex Bennée
2020-02-05 17:10 ` [PATCH v6 10/22] target/arm: prepare for multiple dynamic XMLs Alex Bennée
2020-02-05 17:10 ` [PATCH v6 11/22] target/arm: explicitly encode regnum in our XML Alex Bennée
2020-02-05 17:10 ` Alex Bennée [this message]
2020-02-06 11:19   ` [PATCH v6 12/22] target/arm: default SVE length to 64 bytes for linux-user Richard Henderson
2020-02-05 17:10 ` [PATCH v6 13/22] target/arm: generate xml description of our SVE registers Alex Bennée
2020-02-06 11:20   ` Richard Henderson
2020-02-06 11:20   ` Richard Henderson
2020-02-05 17:10 ` [PATCH v6 14/22] target/arm: don't bother with id_aa64pfr0_read for USER_ONLY Alex Bennée
2020-02-05 17:10 ` [PATCH v6 15/22] tests/tcg/aarch64: userspace system register test Alex Bennée
2020-02-05 17:10 ` [PATCH v6 16/22] configure: allow user to specify what gdb to use Alex Bennée
2020-02-05 17:10 ` [PATCH v6 17/22] tests/guest-debug: add a simple test runner Alex Bennée
2020-02-05 17:10 ` [PATCH v6 18/22] tests/tcg/aarch64: add a gdbstub testcase for SVE registers Alex Bennée
2020-02-05 17:10 ` [PATCH v6 19/22] tests/tcg/aarch64: add SVE iotcl test Alex Bennée
2020-02-05 17:10 ` [PATCH v6 20/22] tests/tcg/aarch64: add test-sve-ioctl guest-debug test Alex Bennée
2020-02-05 17:10 ` [PATCH v6 21/22] gdbstub: change GDBState.last_packet to GByteArray Alex Bennée
2020-02-05 17:10 ` [PATCH v6 22/22] gdbstub: do not split gdb_monitor_write payload Alex Bennée
2020-02-05 18:00 ` [PATCH v6 00/22] gdbstub refactor and SVE support no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200205171031.22582-13-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=alan.hayward@arm.com \
    --cc=damien.hedde@greensocs.com \
    --cc=luis.machado@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).