From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: damien.hedde@greensocs.com, luis.machado@linaro.org,
richard.henderson@linaro.org,
"Laurent Vivier" <laurent@vivier.eu>,
alan.hayward@arm.com, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v6 07/22] target/m68k: use gdb_get_reg helpers
Date: Wed, 5 Feb 2020 17:10:16 +0000 [thread overview]
Message-ID: <20200205171031.22582-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200205171031.22582-1-alex.bennee@linaro.org>
This is cleaner than poking memory directly and will make later
clean-ups easier.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
v3
- fix mem_buf references
- fix mem_buf + len cases
---
target/m68k/helper.c | 29 +++++++++++------------------
1 file changed, 11 insertions(+), 18 deletions(-)
diff --git a/target/m68k/helper.c b/target/m68k/helper.c
index baf7729af00..c23b70f854d 100644
--- a/target/m68k/helper.c
+++ b/target/m68k/helper.c
@@ -72,19 +72,15 @@ static int cf_fpu_gdb_get_reg(CPUM68KState *env, uint8_t *mem_buf, int n)
{
if (n < 8) {
float_status s;
- stfq_p(mem_buf, floatx80_to_float64(env->fregs[n].d, &s));
- return 8;
+ return gdb_get_reg64(mem_buf, floatx80_to_float64(env->fregs[n].d, &s));
}
switch (n) {
case 8: /* fpcontrol */
- stl_be_p(mem_buf, env->fpcr);
- return 4;
+ return gdb_get_reg32(mem_buf, env->fpcr);
case 9: /* fpstatus */
- stl_be_p(mem_buf, env->fpsr);
- return 4;
+ return gdb_get_reg32(mem_buf, env->fpsr);
case 10: /* fpiar, not implemented */
- memset(mem_buf, 0, 4);
- return 4;
+ return gdb_get_reg32(mem_buf, 0);
}
return 0;
}
@@ -112,21 +108,18 @@ static int cf_fpu_gdb_set_reg(CPUM68KState *env, uint8_t *mem_buf, int n)
static int m68k_fpu_gdb_get_reg(CPUM68KState *env, uint8_t *mem_buf, int n)
{
if (n < 8) {
- stw_be_p(mem_buf, env->fregs[n].l.upper);
- memset(mem_buf + 2, 0, 2);
- stq_be_p(mem_buf + 4, env->fregs[n].l.lower);
- return 12;
+ int len = gdb_get_reg16(mem_buf, env->fregs[n].l.upper);
+ len += gdb_get_reg16(mem_buf + len, 0);
+ len += gdb_get_reg64(mem_buf + len, env->fregs[n].l.lower);
+ return len;
}
switch (n) {
case 8: /* fpcontrol */
- stl_be_p(mem_buf, env->fpcr);
- return 4;
+ return gdb_get_reg32(mem_buf, env->fpcr);
case 9: /* fpstatus */
- stl_be_p(mem_buf, env->fpsr);
- return 4;
+ return gdb_get_reg32(mem_buf, env->fpsr);
case 10: /* fpiar, not implemented */
- memset(mem_buf, 0, 4);
- return 4;
+ return gdb_get_reg32(mem_buf, 0);
}
return 0;
}
--
2.20.1
next prev parent reply other threads:[~2020-02-05 17:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 17:10 [PATCH v6 00/22] gdbstub refactor and SVE support Alex Bennée
2020-02-05 17:10 ` [PATCH v6 01/22] gdbstub: make GDBState static and have common init function Alex Bennée
2020-02-05 17:10 ` [PATCH v6 02/22] gdbstub: stop passing GDBState * around and use global Alex Bennée
2020-02-05 17:10 ` [PATCH v6 03/22] gdbstub: move str_buf to GDBState and use GString Alex Bennée
2020-02-05 17:10 ` [PATCH v6 04/22] gdbstub: move mem_buf to GDBState and use GByteArray Alex Bennée
2020-02-05 17:10 ` [PATCH v6 05/22] gdbstub: add helper for 128 bit registers Alex Bennée
2020-02-05 17:10 ` [PATCH v6 06/22] target/arm: use gdb_get_reg helpers Alex Bennée
2020-02-05 17:10 ` Alex Bennée [this message]
2020-02-05 17:10 ` [PATCH v6 08/22] target/i386: " Alex Bennée
2020-02-06 11:14 ` Richard Henderson
2020-02-05 17:10 ` [PATCH v6 09/22] gdbstub: extend GByteArray to read register helpers Alex Bennée
2020-02-05 17:10 ` [PATCH v6 10/22] target/arm: prepare for multiple dynamic XMLs Alex Bennée
2020-02-05 17:10 ` [PATCH v6 11/22] target/arm: explicitly encode regnum in our XML Alex Bennée
2020-02-05 17:10 ` [PATCH v6 12/22] target/arm: default SVE length to 64 bytes for linux-user Alex Bennée
2020-02-06 11:19 ` Richard Henderson
2020-02-05 17:10 ` [PATCH v6 13/22] target/arm: generate xml description of our SVE registers Alex Bennée
2020-02-06 11:20 ` Richard Henderson
2020-02-06 11:20 ` Richard Henderson
2020-02-05 17:10 ` [PATCH v6 14/22] target/arm: don't bother with id_aa64pfr0_read for USER_ONLY Alex Bennée
2020-02-05 17:10 ` [PATCH v6 15/22] tests/tcg/aarch64: userspace system register test Alex Bennée
2020-02-05 17:10 ` [PATCH v6 16/22] configure: allow user to specify what gdb to use Alex Bennée
2020-02-05 17:10 ` [PATCH v6 17/22] tests/guest-debug: add a simple test runner Alex Bennée
2020-02-05 17:10 ` [PATCH v6 18/22] tests/tcg/aarch64: add a gdbstub testcase for SVE registers Alex Bennée
2020-02-05 17:10 ` [PATCH v6 19/22] tests/tcg/aarch64: add SVE iotcl test Alex Bennée
2020-02-05 17:10 ` [PATCH v6 20/22] tests/tcg/aarch64: add test-sve-ioctl guest-debug test Alex Bennée
2020-02-05 17:10 ` [PATCH v6 21/22] gdbstub: change GDBState.last_packet to GByteArray Alex Bennée
2020-02-05 17:10 ` [PATCH v6 22/22] gdbstub: do not split gdb_monitor_write payload Alex Bennée
2020-02-05 18:00 ` [PATCH v6 00/22] gdbstub refactor and SVE support no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205171031.22582-8-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=alan.hayward@arm.com \
--cc=damien.hedde@greensocs.com \
--cc=laurent@vivier.eu \
--cc=luis.machado@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).