From: "Ján Tomko" <jtomko@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "reviewer:Incompatible changes" <libvir-list@redhat.com>,
peter.maydell@linaro.org, qemu-devel@nongnu.org,
mreitz@redhat.com
Subject: Re: [PATCH v2 1/2] docs: Fix typo in qemu-nbd -P replacement
Date: Wed, 5 Feb 2020 23:27:50 +0100 [thread overview]
Message-ID: <20200205222750.GC31521@lpt> (raw)
In-Reply-To: <20200123164650.1741798-2-eblake@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 768 bytes --]
On Thu, Jan 23, 2020 at 10:46:49AM -0600, Eric Blake wrote:
>The suggested replacement for the deprecated 'qemu-nbd -P' referw to
s/referw/refer/
>'file.backing.opt' instead of 'file.file.opt'; using the example
>verbatim results in:
>
>qemu-nbd: Failed to blk_new_open 'driver=raw,offset=1m,size=100m,file.driver=qcow2,file.backing.driver=file,file.backing.filename=file4': A block device must be specified for "file"
>
>Correct this text, prior to actually finishing the deprecation process.
>
>Fixes: 0ae2d54645eb
>Reported-by: Max Reitz <mreitz@redhat.com>
>Signed-off-by: Eric Blake <eblake@redhat.com>
>---
> qemu-deprecated.texi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-05 22:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 16:46 [PATCH v2 0/2] finish qemu-nbd --partition deprecation Eric Blake
2020-01-23 16:46 ` [PATCH v2 1/2] docs: Fix typo in qemu-nbd -P replacement Eric Blake
2020-02-05 22:27 ` Ján Tomko [this message]
2020-01-23 16:46 ` [PATCH v2 2/2] qemu-nbd: Removed deprecated --partition option Eric Blake
2020-02-05 22:28 ` Ján Tomko
2020-01-31 17:11 ` [PATCH v2 0/2] finish qemu-nbd --partition deprecation Eric Blake
2020-02-19 10:53 ` Max Reitz
2020-02-19 13:31 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205222750.GC31521@lpt \
--to=jtomko@redhat.com \
--cc=eblake@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).