From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
jtomko@redhat.com, libvir-list@redhat.com,
Markus Armbruster <armbru@redhat.com>,
jpewhacker@gmail.com, Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH v2 3/6] ui/sdl: implement show-cursor option
Date: Thu, 6 Feb 2020 12:29:05 +0100 [thread overview]
Message-ID: <20200206112908.5002-4-kraxel@redhat.com> (raw)
In-Reply-To: <20200206112908.5002-1-kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---
ui/sdl2.c | 28 ++++++++++++++++++++--------
1 file changed, 20 insertions(+), 8 deletions(-)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index 9030f1c42efb..e18555b10a42 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -161,9 +161,15 @@ static void sdl_update_caption(struct sdl2_console *scon)
}
}
-static void sdl_hide_cursor(void)
+static void sdl_hide_cursor(struct sdl2_console *scon)
{
- if (!cursor_hide) {
+ bool allow_hide_cursor = true;
+
+ if (scon->opts->has_show_cursor && scon->opts->show_cursor) {
+ allow_hide_cursor = false;
+ }
+
+ if (!allow_hide_cursor) {
return;
}
@@ -175,9 +181,15 @@ static void sdl_hide_cursor(void)
}
}
-static void sdl_show_cursor(void)
+static void sdl_show_cursor(struct sdl2_console *scon)
{
- if (!cursor_hide) {
+ bool allow_hide_cursor = true;
+
+ if (scon->opts->has_show_cursor && scon->opts->show_cursor) {
+ allow_hide_cursor = false;
+ }
+
+ if (!allow_hide_cursor) {
return;
}
@@ -216,7 +228,7 @@ static void sdl_grab_start(struct sdl2_console *scon)
SDL_WarpMouseInWindow(scon->real_window, guest_x, guest_y);
}
} else {
- sdl_hide_cursor();
+ sdl_hide_cursor(scon);
}
SDL_SetWindowGrab(scon->real_window, SDL_TRUE);
gui_grab = 1;
@@ -227,7 +239,7 @@ static void sdl_grab_end(struct sdl2_console *scon)
{
SDL_SetWindowGrab(scon->real_window, SDL_FALSE);
gui_grab = 0;
- sdl_show_cursor();
+ sdl_show_cursor(scon);
sdl_update_caption(scon);
}
@@ -658,7 +670,7 @@ static void sdl_mouse_warp(DisplayChangeListener *dcl,
if (on) {
if (!guest_cursor) {
- sdl_show_cursor();
+ sdl_show_cursor(scon);
}
if (gui_grab || qemu_input_is_absolute() || absolute_enabled) {
SDL_SetCursor(guest_sprite);
@@ -667,7 +679,7 @@ static void sdl_mouse_warp(DisplayChangeListener *dcl,
}
}
} else if (gui_grab) {
- sdl_hide_cursor();
+ sdl_hide_cursor(scon);
}
guest_cursor = on;
guest_x = x, guest_y = y;
--
2.18.1
next prev parent reply other threads:[~2020-02-06 11:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 11:29 [PATCH v2 0/6] ui: rework -show-cursor option Gerd Hoffmann
2020-02-06 11:29 ` [PATCH v2 1/6] ui: add show-cursor option Gerd Hoffmann
2020-02-06 12:14 ` Markus Armbruster
2020-02-06 11:29 ` [PATCH v2 2/6] ui/gtk: implement " Gerd Hoffmann
2020-02-06 11:29 ` Gerd Hoffmann [this message]
2020-02-06 11:29 ` [PATCH v2 4/6] ui/cocoa: " Gerd Hoffmann
2020-02-06 11:29 ` [PATCH v2 5/6] ui: wire up legacy -show-cursor option Gerd Hoffmann
2020-02-06 11:29 ` [PATCH v2 6/6] ui: deprecate " Gerd Hoffmann
2020-02-06 11:52 ` [PATCH v2 0/6] ui: rework " Peter Maydell
2020-02-06 13:20 ` Gerd Hoffmann
2020-02-06 14:39 ` Peter Maydell
2020-02-07 8:03 ` Erik Skultety
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206112908.5002-4-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=jpewhacker@gmail.com \
--cc=jtomko@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).