From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
jtomko@redhat.com, libvir-list@redhat.com,
Markus Armbruster <armbru@redhat.com>,
jpewhacker@gmail.com, Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH v3 5/7] ui/gtk: implement show-cursor option
Date: Fri, 7 Feb 2020 11:17:51 +0100 [thread overview]
Message-ID: <20200207101753.25812-6-kraxel@redhat.com> (raw)
In-Reply-To: <20200207101753.25812-1-kraxel@redhat.com>
When specified just set null_cursor to NULL so we get the default
pointer instead of a blank pointer.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/gtk.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index d18892d1de61..a685d1ae0848 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -2243,8 +2243,12 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts)
textdomain("qemu");
window_display = gtk_widget_get_display(s->window);
- s->null_cursor = gdk_cursor_new_for_display(window_display,
- GDK_BLANK_CURSOR);
+ if (s->opts->has_show_cursor && s->opts->show_cursor) {
+ s->null_cursor = NULL; /* default pointer */
+ } else {
+ s->null_cursor = gdk_cursor_new_for_display(window_display,
+ GDK_BLANK_CURSOR);
+ }
s->mouse_mode_notifier.notify = gd_mouse_mode_change;
qemu_add_mouse_mode_change_notifier(&s->mouse_mode_notifier);
--
2.18.1
next prev parent reply other threads:[~2020-02-07 10:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 10:17 [PATCH v3 0/7] ui: rework -show-cursor option Gerd Hoffmann
2020-02-07 10:17 ` [PATCH v3 1/7] ui: add show-cursor option Gerd Hoffmann
2020-02-07 13:56 ` Markus Armbruster
2020-02-07 10:17 ` [PATCH v3 2/7] ui: wire up legacy -show-cursor option Gerd Hoffmann
2020-02-07 10:17 ` [PATCH v3 3/7] ui/sdl: switch to new show-cursor option Gerd Hoffmann
2020-02-07 10:17 ` [PATCH v3 4/7] ui/cocoa: " Gerd Hoffmann
2020-02-07 10:17 ` Gerd Hoffmann [this message]
2020-02-07 14:37 ` [PATCH v3 5/7] ui/gtk: implement " Joshua Watt
2020-02-12 11:57 ` Gerd Hoffmann
2020-02-07 10:17 ` [PATCH v3 6/7] ui: drop curor_hide global variable Gerd Hoffmann
2020-02-07 10:17 ` [PATCH v3 7/7] ui: deprecate legacy -show-cursor option Gerd Hoffmann
2020-02-08 22:52 ` [PATCH v3 0/7] ui: rework " Ján Tomko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207101753.25812-6-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=jpewhacker@gmail.com \
--cc=jtomko@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).