qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
	robert.foley@linaro.org, "Euler Robot" <euler.robot@huawei.com>,
	robhenry@microsoft.com, aaron@os.amperecomputing.com,
	cota@braap.org, kuhn.chenqun@huawei.com, peter.puhov@linaro.org,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH  v1 3/5] tests/plugin: prevent uninitialized warning
Date: Fri,  7 Feb 2020 15:01:16 +0000	[thread overview]
Message-ID: <20200207150118.23007-4-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200207150118.23007-1-alex.bennee@linaro.org>

From: Chen Qun <kuhn.chenqun@huawei.com>

According to the glibc function requirements, we need initialise
 the variable. Otherwise there will be compilation warnings:

glib-autocleanups.h:28:3: warning: ‘out’ may be
used uninitialized in this function [-Wmaybe-uninitialized]
   g_free (*pp);
   ^~~~~~~~~~~~

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20200206093238.203984-1-kuhn.chenqun@huawei.com>
[AJB: uses Thomas's single line allocation]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/plugin/bb.c   | 6 +++---
 tests/plugin/insn.c | 3 +--
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/tests/plugin/bb.c b/tests/plugin/bb.c
index f30bea08dcc..df19fd359df 100644
--- a/tests/plugin/bb.c
+++ b/tests/plugin/bb.c
@@ -22,9 +22,9 @@ static bool do_inline;
 
 static void plugin_exit(qemu_plugin_id_t id, void *p)
 {
-    g_autofree gchar *out;
-    out = g_strdup_printf("bb's: %" PRIu64", insns: %" PRIu64 "\n",
-                          bb_count, insn_count);
+    g_autofree gchar *out = g_strdup_printf(
+        "bb's: %" PRIu64", insns: %" PRIu64 "\n",
+        bb_count, insn_count);
     qemu_plugin_outs(out);
 }
 
diff --git a/tests/plugin/insn.c b/tests/plugin/insn.c
index 0a8f5a0000e..a9a6e412373 100644
--- a/tests/plugin/insn.c
+++ b/tests/plugin/insn.c
@@ -44,8 +44,7 @@ static void vcpu_tb_trans(qemu_plugin_id_t id, struct qemu_plugin_tb *tb)
 
 static void plugin_exit(qemu_plugin_id_t id, void *p)
 {
-    g_autofree gchar *out;
-    out = g_strdup_printf("insns: %" PRIu64 "\n", insn_count);
+    g_autofree gchar *out = g_strdup_printf("insns: %" PRIu64 "\n", insn_count);
     qemu_plugin_outs(out);
 }
 
-- 
2.20.1



  parent reply	other threads:[~2020-02-07 15:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 15:01 [PATCH v1 0/5] plugins/next Alex Bennée
2020-02-07 15:01 ` [PATCH v1 1/5] docs/devel: document query handle lifetimes Alex Bennée
2020-02-07 16:38   ` Robert Foley
2020-02-09 18:20   ` Richard Henderson
2020-02-07 15:01 ` [PATCH v1 2/5] plugins/core: add missing break in cb_to_tcg_flags Alex Bennée
2020-02-11 17:56   ` Richard Henderson
2020-02-07 15:01 ` Alex Bennée [this message]
2020-02-11 17:57   ` [PATCH v1 3/5] tests/plugin: prevent uninitialized warning Richard Henderson
2020-02-07 15:01 ` [PATCH v1 4/5] target/riscv: progressively load the instruction during decode Alex Bennée
2020-02-07 16:33   ` Robert Foley
2020-02-07 16:47     ` Alex Bennée
2020-02-11 18:00   ` Richard Henderson
2020-02-07 15:01 ` [PATCH v1 5/5] tests/plugins: make howvec clean-up after itself Alex Bennée
2020-02-10 19:34   ` Robert Foley
2020-02-11 18:01   ` Richard Henderson
2020-02-07 20:55 ` [PATCH v1 0/5] plugins/next no-reply
2020-02-07 21:27 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200207150118.23007-4-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aaron@os.amperecomputing.com \
    --cc=cota@braap.org \
    --cc=euler.robot@huawei.com \
    --cc=kuhn.chenqun@huawei.com \
    --cc=peter.puhov@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=robert.foley@linaro.org \
    --cc=robhenry@microsoft.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).