From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B145C47409 for ; Sat, 8 Feb 2020 09:27:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DF8021741 for ; Sat, 8 Feb 2020 09:27:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="ijcn8Llo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DF8021741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0MOP-00079w-AS for qemu-devel@archiver.kernel.org; Sat, 08 Feb 2020 04:27:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60314) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j0MNB-0005Ql-8f for qemu-devel@nongnu.org; Sat, 08 Feb 2020 04:25:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j0MN9-0000T7-Tc for qemu-devel@nongnu.org; Sat, 08 Feb 2020 04:25:57 -0500 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:54295 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j0MN8-0000A0-2O; Sat, 08 Feb 2020 04:25:54 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 48F6Gd20KLz9sPK; Sat, 8 Feb 2020 20:25:45 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1581153945; bh=6RR1AqCdojKlRABvWytA0f8y/htSmvLgvdjGZEwETaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ijcn8Lloc36esWOFlceEhewFluWObCk8bzULPpfjAzT76Qr+B2MjivWp+5nF0KosD o+b+Fv0ErKZQ1zcQggp2UMFT13b1F2Tjf20xc7l7I/k7bBxIxguF3yZtGWUI0nEeCo 2hoa8PGCObleLRkvV7PHHpMpMjJCUAG/te9F4MBw= Date: Sat, 8 Feb 2020 20:25:36 +1100 From: David Gibson To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v4 3/3] vl: Abort if multiple machines are registered as default Message-ID: <20200208092536.GD219689@umbus.fritz.box> References: <20200207161948.15972-1-philmd@redhat.com> <20200207161948.15972-4-philmd@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2iBwrppp/7QCDedR" Content-Disposition: inline In-Reply-To: <20200207161948.15972-4-philmd@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wulff , Sagar Karandikar , "Michael S. Tsirkin" , Anthony Green , Mark Cave-Ayland , qemu-devel@nongnu.org, Alistair Francis , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Jia Liu , qemu-trivial@nongnu.org, Helge Deller , David Hildenbrand , Magnus Damm , Halil Pasic , Christian Borntraeger , Palmer Dabbelt , Aleksandar Rikalo , Artyom Tarasenko , Eduardo Habkost , Richard Henderson , qemu-s390x@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Stafford Horne , Richard Henderson , qemu-riscv@nongnu.org, Thomas Huth , Bastian Koppelmann , Cornelia Huck , Laurent Vivier , Michael Walle , qemu-ppc@nongnu.org, Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --2iBwrppp/7QCDedR Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 07, 2020 at 05:19:48PM +0100, Philippe Mathieu-Daud=E9 wrote: > It would be confusing to have multiple default machines. > Abort if this ever occurs. >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 Reviewed-by: David Gibson > --- > v2: Use assert() instead of human friendly message (Marc-Andr=E9) > v3: Move the check to find_machine() (Michael) >=20 > Cc: Marc-Andr=E9 Lureau > Cc: Laurent Vivier > Cc: Michael S. Tsirkin > --- > vl.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/vl.c b/vl.c > index 7dcb0879c4..ebc203af0d 100644 > --- a/vl.c > +++ b/vl.c > @@ -1184,16 +1184,18 @@ static MachineClass *find_machine(const char *nam= e, GSList *machines) > static MachineClass *find_default_machine(GSList *machines) > { > GSList *el; > + MachineClass *default_machineclass =3D NULL; > =20 > for (el =3D machines; el; el =3D el->next) { > MachineClass *mc =3D el->data; > =20 > if (mc->is_default) { > - return mc; > + assert(default_machineclass =3D=3D NULL && "Multiple default= machines"); > + default_machineclass =3D mc; > } > } > =20 > - return NULL; > + return default_machineclass; > } > =20 > static int machine_help_func(QemuOpts *opts, MachineState *machine) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --2iBwrppp/7QCDedR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAl4+fpAACgkQbDjKyiDZ s5KqoQ//b5icTjA+cBYQdVG7nS2yLMmcdrJyAOdFBPIEZ4DTV94zEbZMriYCZTfQ YdDEIjK6vBFxaD98Br+VqXDuBCj4UuR+EUgiRtEmeRZQ5bIN/T1Bf85imSNBzwiP /2b/wLoVOt0I0f15qC0fPZejL91/XXtrut9jbSzPb82H6qvNJMfGWHQg20ZensOV cNJ9dsPIrKCJGuYCk9KHUnDdeuT+jNfcjaBg19zlZHWB9LuYJi3y1ulI0s15akcW EptBKiQ+KicBfyXoHsa5SCYIa31tL9GR0sBgbDMCvE6TfbGILUzF5g8rJ924gnQu nD4Ae+OAZNP5HVPsNKbwTrCPDc+bQTGxKIZeK8Yq95I1OTzJYFCQVaF0VBeLP6jm JwIWNOSWHAjUtUW0+LLEsKx/f+1+xMOq9BdeI/9IajymvhusNL4S38FcGd/T8iRV sQ1bqXm3ZuB/XcEbXeIttksC1XZyBF5tA4Ds6qCR4gzYNkspEzVLffe4lpE4Flkp ePzhYeANFx7nc/uvi7OBD2hZjUIQXGFpnXFa/bSP5Nnle5EmUvZdtU8JSAAktjHr pn2BsaTifAn4bvhdBaLekQEyhdlG67zRtO3Y3h5isKSmSrnw3POnEJ1PIA7GPOM6 dLAtEDZOzOh2a2d6OrlS+VQC6n2JPgiIAR5EuXSqnWYuFwhVBqU= =rtQm -----END PGP SIGNATURE----- --2iBwrppp/7QCDedR--