From: Gerd Hoffmann <kraxel@redhat.com>
To: Joshua Watt <jpewhacker@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
jtomko@redhat.com, libvir-list@redhat.com, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 5/7] ui/gtk: implement show-cursor option
Date: Wed, 12 Feb 2020 12:57:33 +0100 [thread overview]
Message-ID: <20200212115733.eha47pyo4wos6fql@sirius.home.kraxel.org> (raw)
In-Reply-To: <b0dca00d-5d35-a139-b5d0-1777c92b23a0@gmail.com>
> > + if (s->opts->has_show_cursor && s->opts->show_cursor) {
> > + s->null_cursor = NULL; /* default pointer */
> > + } else {
> > + s->null_cursor = gdk_cursor_new_for_display(window_display,
> > + GDK_BLANK_CURSOR);
> > + }
>
> I think it would make more sense to have all the logic related to what
> cursor is used in the same location, instead of split up between here and
> gd_update_cursor().
Note that it isn't that simple. There are a few more places in
gd_grab_*() which use s->null_cursor and would need adaption.
cheers,
Gerd
next prev parent reply other threads:[~2020-02-12 11:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 10:17 [PATCH v3 0/7] ui: rework -show-cursor option Gerd Hoffmann
2020-02-07 10:17 ` [PATCH v3 1/7] ui: add show-cursor option Gerd Hoffmann
2020-02-07 13:56 ` Markus Armbruster
2020-02-07 10:17 ` [PATCH v3 2/7] ui: wire up legacy -show-cursor option Gerd Hoffmann
2020-02-07 10:17 ` [PATCH v3 3/7] ui/sdl: switch to new show-cursor option Gerd Hoffmann
2020-02-07 10:17 ` [PATCH v3 4/7] ui/cocoa: " Gerd Hoffmann
2020-02-07 10:17 ` [PATCH v3 5/7] ui/gtk: implement " Gerd Hoffmann
2020-02-07 14:37 ` Joshua Watt
2020-02-12 11:57 ` Gerd Hoffmann [this message]
2020-02-07 10:17 ` [PATCH v3 6/7] ui: drop curor_hide global variable Gerd Hoffmann
2020-02-07 10:17 ` [PATCH v3 7/7] ui: deprecate legacy -show-cursor option Gerd Hoffmann
2020-02-08 22:52 ` [PATCH v3 0/7] ui: rework " Ján Tomko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212115733.eha47pyo4wos6fql@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=jpewhacker@gmail.com \
--cc=jtomko@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).