From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42665C2BA83 for ; Fri, 14 Feb 2020 10:38:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 050AA2067D for ; Fri, 14 Feb 2020 10:38:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Wi1advPJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 050AA2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2YMn-0004dz-8r for qemu-devel@archiver.kernel.org; Fri, 14 Feb 2020 05:38:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38696) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2YM6-0003yx-0h for qemu-devel@nongnu.org; Fri, 14 Feb 2020 05:37:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2YM4-0005EU-VD for qemu-devel@nongnu.org; Fri, 14 Feb 2020 05:37:53 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:55324 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j2YM4-0005DG-Qd for qemu-devel@nongnu.org; Fri, 14 Feb 2020 05:37:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581676671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UWyq4h0NgncesMDM0Z4Cqn9MVDdOhS+F7Q564s5JckI=; b=Wi1advPJyp1poXZy+XsqXLDA1vvehhaTRPDM4SCujm89pidzwsh9OE1AXS1Ro/RYt/G6uA c7g7sVrdfEuF52ZHpey5MkYkcUGaufN9i6tLq74jsM7YWrZhpCc40Zr2/H61uxMm4redOi x1RwuiznnwwwmI5TpyHkRqRLrSGOW2g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-YciX6dN-Nr6Y-PROndN8jQ-1; Fri, 14 Feb 2020 05:37:45 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7B5E18AB2C2; Fri, 14 Feb 2020 10:37:44 +0000 (UTC) Received: from gondolin (dhcp-192-195.str.redhat.com [10.33.192.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id A16905C115; Fri, 14 Feb 2020 10:37:41 +0000 (UTC) Date: Fri, 14 Feb 2020 11:37:39 +0100 From: Cornelia Huck To: Michal Privoznik Subject: Re: [PATCH v2] Report stringified errno in VFIO related errors Message-ID: <20200214113739.7969d81a.cohuck@redhat.com> In-Reply-To: <4949c3ecf1a32189b8a4b5eb4b0fd04c1122501d.1581674006.git.mprivozn@redhat.com> References: <4949c3ecf1a32189b8a4b5eb4b0fd04c1122501d.1581674006.git.mprivozn@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: YciX6dN-Nr6Y-PROndN8jQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, alex.williamson@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 14 Feb 2020 10:55:19 +0100 Michal Privoznik wrote: > In a few places we report errno formatted as a negative integer. > This is not as user friendly as it can be. Use strerror() and/or > error_setg_errno() instead. > > Signed-off-by: Michal Privoznik > --- > > v1 posted here: > > https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg03623.html > > diff to v1: > - Change error reporting in vfio_dma_unmap() too as I missed it in v1. > > hw/vfio/common.c | 4 ++-- > util/vfio-helpers.c | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Cornelia Huck