From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
qemu-block@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH 0/5] aio-posix: towards an O(1) event loop
Date: Fri, 14 Feb 2020 17:17:07 +0000 [thread overview]
Message-ID: <20200214171712.541358-1-stefanha@redhat.com> (raw)
This patch series makes AioHandler deletion and dispatch O(1) with respect to
the total number of registered handlers. The event loop has scalability
problems when many AioHandlers are registered because it is O(n). Linux
epoll(7) is used to avoid scanning over all pollfds but parts of the code still
scan all AioHandlers.
This series reduces QEMU CPU utilization and therefore increases IOPS,
especially for guests that have many devices. It was tested with 32 vCPUs, 2
virtio-blk,num-queues=1,iothread=iothread1, and 99
virtio-blk,num-queues=32,iothread=iothread1 devices. Using an IOThread is
necessary because this series does not improve the glib main loop, a non-goal
since the glib API is inherently O(n).
AioContext polling remains O(n) and will be addressed in a separate patch
series. This patch series increases IOPS from 260k to 300k when AioContext
polling is commented out
(rw=randread,bs=4k,iodepth=32,ioengine=libaio,direct=1).
Stefan Hajnoczi (5):
aio-posix: fix use after leaving scope in aio_poll()
aio-posix: don't pass ns timeout to epoll_wait()
qemu/queue.h: add QLIST_SAFE_REMOVE()
aio-posix: make AioHandler deletion O(1)
aio-posix: make AioHandler dispatch O(1) with epoll
block.c | 5 +-
chardev/spice.c | 4 +-
include/block/aio.h | 6 +-
include/qemu/queue.h | 17 +++++
util/aio-posix.c | 172 +++++++++++++++++++++++++++++--------------
5 files changed, 141 insertions(+), 63 deletions(-)
--
2.24.1
next reply other threads:[~2020-02-14 17:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 17:17 Stefan Hajnoczi [this message]
2020-02-14 17:17 ` [PATCH 1/5] aio-posix: fix use after leaving scope in aio_poll() Stefan Hajnoczi
2020-02-19 7:02 ` Sergio Lopez
2020-02-14 17:17 ` [PATCH 2/5] aio-posix: don't pass ns timeout to epoll_wait() Stefan Hajnoczi
2020-02-19 10:12 ` Sergio Lopez
2020-02-14 17:17 ` [PATCH 3/5] qemu/queue.h: add QLIST_SAFE_REMOVE() Stefan Hajnoczi
2020-02-19 10:30 ` Sergio Lopez
2020-02-14 17:17 ` [PATCH 4/5] aio-posix: make AioHandler deletion O(1) Stefan Hajnoczi
2020-02-19 10:41 ` Sergio Lopez
2020-02-14 17:17 ` [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll Stefan Hajnoczi
2020-02-19 11:00 ` Sergio Lopez
2020-02-19 11:13 ` Paolo Bonzini
2020-02-21 12:59 ` Stefan Hajnoczi
2020-02-21 13:06 ` Paolo Bonzini
2020-02-21 14:44 ` Stefan Hajnoczi
2020-02-21 14:47 ` Stefan Hajnoczi
2020-02-21 15:04 ` Paolo Bonzini
2020-02-21 15:29 ` Stefan Hajnoczi
2020-02-21 15:37 ` Paolo Bonzini
2020-02-21 15:29 ` [PATCH 0/5] aio-posix: towards an O(1) event loop Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214171712.541358-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).