From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH 0/4] tcg: Fix for Bug 1863508
Date: Sun, 16 Feb 2020 18:59:53 -0800 [thread overview]
Message-ID: <20200217025957.12031-1-richard.henderson@linaro.org> (raw)
The comment in tcg-runtime-gvec.c about CONFIG_VECTOR16 says that
tcg-op-gvec.c has eliminated size 8 vectors, and only passes on
multiples of 16. This may have been true of the first few operations,
but is not true of all operations.
In particular, multiply, shift by scalar, and compare of 8- and 16-bit
elements are not expanded inline if host vector operations are not
supported.
For an x86_64 host that does not support AVX, this means that we will
fall back to the helper, which will attempt to use SSE instructions,
which will SEGV on an invalid 8-byte aligned memory operation.
The first patch removes the CONFIG_VECTOR16 code and configuration;
the subsequent patches tidy up tcg-runtime-gvec.c.
r~
Richard Henderson (4):
tcg: Remove CONFIG_VECTOR16
tcg: Tidy tcg-runtime-gvec.c types
tcg: Tidy tcg-runtime-gvec.c DUP*
tcg: Remove tcg-runtime-gvec.c DO_CMP0
configure | 56 -------
accel/tcg/tcg-runtime-gvec.c | 298 ++++++++++++++---------------------
2 files changed, 116 insertions(+), 238 deletions(-)
--
2.20.1
next reply other threads:[~2020-02-17 3:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 2:59 Richard Henderson [this message]
2020-02-17 2:59 ` [PATCH 1/4] tcg: Remove CONFIG_VECTOR16 Richard Henderson
2020-02-17 2:59 ` [PATCH 2/4] tcg: Tidy tcg-runtime-gvec.c types Richard Henderson
2020-02-17 11:00 ` Philippe Mathieu-Daudé
2020-02-17 2:59 ` [PATCH 3/4] tcg: Tidy tcg-runtime-gvec.c DUP* Richard Henderson
2020-02-17 11:02 ` Philippe Mathieu-Daudé
2020-02-17 2:59 ` [PATCH 4/4] tcg: Remove tcg-runtime-gvec.c DO_CMP0 Richard Henderson
2020-02-17 3:10 ` [PATCH 0/4] tcg: Fix for Bug 1863508 no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217025957.12031-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).