From: "Ján Tomko" <jtomko@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v2 2/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment
Date: Mon, 17 Feb 2020 12:42:28 +0100 [thread overview]
Message-ID: <20200217114228.GA7281@lpt> (raw)
In-Reply-To: <20200217094240.9927-3-philmd@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
On Mon, Feb 17, 2020 at 10:42:39AM +0100, Philippe Mathieu-Daudé wrote:
>Fix warning reported by Clang static code analyzer:
>
> CC tools/virtiofsd/passthrough_ll.o
> tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to 'newfd' is never read
> newfd = -1;
> ^ ~~
> tools/virtiofsd/passthrough_ll.c:942:9: warning: Value stored to 'newfd' is never read
> newfd = -1;
> ^ ~~
>
>Fixes: 7c6b66027
>Reported-by: Clang Static Analyzer
>Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>---
>v2: do not set newfd, use it (jtomko)
>---
> tools/virtiofsd/passthrough_ll.c | 2 --
> 1 file changed, 2 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-17 11:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 9:42 [PATCH v2 0/3] tools/virtiofsd: Fix warning reported by Clang static code analyzer Philippe Mathieu-Daudé
2020-02-17 9:42 ` [PATCH v2 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment Philippe Mathieu-Daudé
2020-02-17 11:37 ` Dr. David Alan Gilbert
2020-02-17 14:12 ` Philippe Mathieu-Daudé
2020-02-17 9:42 ` [PATCH v2 2/3] " Philippe Mathieu-Daudé
2020-02-17 11:42 ` Ján Tomko [this message]
2020-02-17 12:07 ` Dr. David Alan Gilbert
2020-02-17 9:42 ` [RFC PATCH v2 3/3] tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header::error value Philippe Mathieu-Daudé
2020-02-17 20:06 ` Dr. David Alan Gilbert
2020-02-18 6:07 ` Philippe Mathieu-Daudé
2020-02-18 9:51 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217114228.GA7281@lpt \
--to=jtomko@redhat.com \
--cc=dgilbert@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).