[RFC PATCH 0/6] Travis: Change default environment to Ubuntu Bionic

[RFC PATCH 0/6] Travis: Change default environment to Ubuntu Bionic

[Wainer dos Santos Moschetta]

Most of the Travis jobs currently run on Ubuntu 16.04 (Xenial),
and some are already using 18.04 (Bionic). Other job will [1]
need the swap very soon. On Travis's Bionic environment it is
allowed the use of nested virtualization, so some tests relying
on kvm can be executed (currently they are skipped).

There is one problem [2] with libssh-dev on Ubuntu Bionic
though. Considering that, on this series I simply does not install it,
so QEMU is built without libssh support. I don't think this is
an impediment for this change anyway, if there is a need to test libssh
support we can add a single Xenial-based job for that.

This series was tested on [3]. The following jobs are intermittently
failing, I ran 3x each:

'GCC check-acceptance': 1 (Interrupted test)
'GCC plugins check-tcg (user)': 1 (job timeout)
'GCC check-tcg (some-softmmu)': 2 (docker OCI runtime start failed)
'GCC plugins check-tcg (some-softmmu)':  1 (OCI runtime start failed)

I've seen [4] those errors related with docker OCI on Xenial too.

Thanks!
- wainer

REFERENCES
[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg677078.html
[2] https://bugs.launchpad.net/qemu/+bug/1838763
[3] https://travis-ci.org/wainersm/qemu/builds/651549376
[4] https://travis-ci.org/qemu/qemu/builds/651506018

Wainer dos Santos Moschetta (6):
  travis.yml: Bump default environment to Ubuntu Bionic
  travis.yml: Fix 'GCC9 with sanitizers' job on Ubuntu Bionic
  travis.yml: Fix 'GCC check-acceptance' job on Ubuntu Bionic
  travis.yml: Fix 'Clang (main-softmmu)' job on Ubuntu Bionic
  travis.yml: Run '[ppc64] GCC check-tcg' job on Ubuntu Bionic
  travis.yml: Run '[aarch64] GCC check-tcg' job on Ubuntu Bionic

 .travis.yml | 79 ++++++++++-------------------------------------------
 1 file changed, 14 insertions(+), 65 deletions(-)

-- 
2.24.1

[RFC PATCH 1/6] travis.yml: Bump default environment to Ubuntu Bionic

[Wainer dos Santos Moschetta]

Currently some KVM tests are skipped because Travis' Ubuntu 16.04 (Xenial)
does not provide nested virtualization (unlike Travis' Ubuntu 18.04). So
this switch the default job environment from Ubuntu Xenial to 18.04 (Bionic).

Notes:

1. The Ubuntu Bionic's libssh-dev package has a bug [1] that prevents QEMU
  from being built with ssh support. Therefore, the libssh-dev is not even
  installed in the job environment until a fix is not shipped.

  [1] https://bugs.launchpad.net/qemu/+bug/1838763

2. The '[aarch64] GCC check-tcg' and '[ppc64] GCC check-tcg' jobs
  explicitly use Xenial so they aren't converted on this patch.

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
 .travis.yml | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 5887055951..e46c44bbee 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,7 +1,7 @@
-# The current Travis default is a VM based 16.04 Xenial on GCE
+# The current Travis default is a VM based 18.04 Xenial on GCE
 # Additional builds with specific requirements for a full VM need to
 # be added as additional matrix: entries later on
-dist: xenial
+dist: bionic
 language: c
 compiler:
   - gcc
@@ -9,7 +9,7 @@ cache:
   # There is one cache per branch and compiler version.
   # characteristics of each job are used to identify the cache:
   # - OS name (currently, linux, osx, or windows)
-  # - OS distribution (for Linux, xenial, trusty, or precise)
+  # - OS distribution (for Linux, bionic, xenial, trusty, or precise)
   # - macOS image name (e.g., xcode7.2)
   # - Names and values of visible environment variables set in .travis.yml or Settings panel
   timeout: 1200
@@ -43,7 +43,9 @@ addons:
       - libseccomp-dev
       - libspice-protocol-dev
       - libspice-server-dev
-      - libssh-dev
+# It should not install libssh-dev until the following bug is fixed:
+# https://bugs.launchpad.net/qemu/+bug/1838763
+#     - libssh-dev
       - liburcu-dev
       - libusb-1.0-0-dev
       - libvdeplug-dev
@@ -184,8 +186,7 @@ matrix:
 
 
     # Check we can build docs and tools (out of tree)
-    - name: "tools and docs (bionic)"
-      dist: bionic
+    - name: "tools and docs"
       env:
         - BUILD_DIR="out-of-tree/build/dir" SRC_DIR="../../.."
         - BASE_CONFIG="--enable-tools --enable-docs"
@@ -480,7 +481,6 @@ matrix:
 
     - name: "[s390x] GCC check-tcg"
       arch: s390x
-      dist: bionic
       addons:
         apt_packages:
           - libaio-dev
-- 
2.24.1

[RFC PATCH 2/6] travis.yml: Fix 'GCC9 with sanitizers' job on Ubuntu Bionic

[Wainer dos Santos Moschetta]

This changes the 'GCC9 with sanitizers' job to run correctly
on Ubuntu Bionic. It was needed to solved the problems:

1) The new environment changed how APT sources are handled,
resulting on the error:

```
Disallowing sources: ubuntu-toolchain-r-test

To add unlisted APT sources, follow instructions in https://docs.travis-ci.com/user/installing-dependencies#Installing-Packages-with-the-APT-Addon
```

Thus, the reference to 'ubuntu-toolchain-r-test' is passed via
'sourceline' now.

2) Adjusted the name of some packages

3) Libssh-dev is not installed due known issue on Bionic

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
 .travis.yml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index e46c44bbee..232f84d196 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -336,7 +336,7 @@ matrix:
           update: true
           sources:
             # PPAs for newer toolchains
-            - ubuntu-toolchain-r-test
+            - sourceline: 'ppa:ubuntu-toolchain-r/test'
           packages:
             # Extra toolchains
             - gcc-9
@@ -346,7 +346,7 @@ matrix:
             - libattr1-dev
             - libbrlapi-dev
             - libcap-ng-dev
-            - libgnutls-dev
+            - libgnutls28-dev
             - libgtk-3-dev
             - libiscsi-dev
             - liblttng-ust-dev
@@ -354,14 +354,15 @@ matrix:
             - libncurses5-dev
             - libnss3-dev
             - libpixman-1-dev
-            - libpng12-dev
+            - libpng-dev
             - librados-dev
             - libsdl2-dev
             - libsdl2-image-dev
             - libseccomp-dev
             - libspice-protocol-dev
             - libspice-server-dev
-            - libssh-dev
+# https://bugs.launchpad.net/qemu/+bug/1838763
+#            - libssh-dev
             - liburcu-dev
             - libusb-1.0-0-dev
             - libvte-2.91-dev
-- 
2.24.1

[RFC PATCH 3/6] travis.yml: Fix 'GCC check-acceptance' job on Ubuntu Bionic

[Wainer dos Santos Moschetta]

Ubuntu Bionic does not provide python3.5-venv and then
the 'GCC check-acceptance' job was changed to use python3.6-venv.

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 232f84d196..4089e9672a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -323,7 +323,7 @@ matrix:
           packages:
             - python3-pil
             - python3-pip
-            - python3.5-venv
+            - python3.6-venv
             - rpm2cpio
             - tesseract-ocr
             - tesseract-ocr-eng
-- 
2.24.1

[RFC PATCH 4/6] travis.yml: Fix 'Clang (main-softmmu)' job on Ubuntu Bionic

[Wainer dos Santos Moschetta]

On Ubuntu Bionic environment the build with Clang's sanitizer
fails with error:

```
LINK    tests/qemu-iotests/socket_scm_helper

tests/qemu-iotests/socket_scm_helper.o: In function `send_fd':

/home/travis/build/wainersm/qemu/tests/qemu-iotests/socket_scm_helper.c:53: undefined reference to `__ubsan_handle_type_mismatch_v1'
```

In order to solve that problem it was needed to explicitly pass
'--cxx=clang++' to the configure.

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 4089e9672a..59b9eb20b7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -215,7 +215,7 @@ matrix:
       compiler: clang
       before_script:
         - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR}
-        - ${SRC_DIR}/configure ${CONFIG} --extra-cflags="-fsanitize=undefined -Werror" || { cat config.log && exit 1; }
+        - ${SRC_DIR}/configure ${CONFIG} --cc=clang --cxx=clang++ --extra-cflags="-fsanitize=undefined -Werror" || { cat config.log && exit 1; }
 
 
     - name: "Clang (other-softmmu)"
-- 
2.24.1

[RFC PATCH 5/6] travis.yml: Run '[ppc64] GCC check-tcg' job on Ubuntu Bionic

[Wainer dos Santos Moschetta]

Converted the '[ppc64] GCC check-tcg' job to run on Ubuntu
18.04 (Bionic).

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
 .travis.yml | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 59b9eb20b7..c6465ae807 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -450,32 +450,6 @@ matrix:
 
     - name: "[ppc64] GCC check-tcg"
       arch: ppc64le
-      dist: xenial
-      addons:
-        apt_packages:
-          - libaio-dev
-          - libattr1-dev
-          - libbrlapi-dev
-          - libcap-ng-dev
-          - libgcrypt20-dev
-          - libgnutls28-dev
-          - libgtk-3-dev
-          - libiscsi-dev
-          - liblttng-ust-dev
-          - libncurses5-dev
-          - libnfs-dev
-          - libnss3-dev
-          - libpixman-1-dev
-          - libpng-dev
-          - librados-dev
-          - libsdl2-dev
-          - libseccomp-dev
-          - liburcu-dev
-          - libusb-1.0-0-dev
-          - libvdeplug-dev
-          - libvte-2.91-dev
-          # Tests dependencies
-          - genisoimage
       env:
         - TEST_CMD="make check check-tcg V=1"
         - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},ppc64le-linux-user"
-- 
2.24.1

[RFC PATCH 6/6] travis.yml: Run '[aarch64] GCC check-tcg' job on Ubuntu Bionic

[Wainer dos Santos Moschetta]

Converted the '[aarch64] GCC check-tcg' job to run on Ubuntu
18.04 (Bionic).

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
 .travis.yml | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index c6465ae807..e0d2475899 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -418,32 +418,6 @@ matrix:
 
     - name: "[aarch64] GCC check-tcg"
       arch: arm64
-      dist: xenial
-      addons:
-        apt_packages:
-          - libaio-dev
-          - libattr1-dev
-          - libbrlapi-dev
-          - libcap-ng-dev
-          - libgcrypt20-dev
-          - libgnutls28-dev
-          - libgtk-3-dev
-          - libiscsi-dev
-          - liblttng-ust-dev
-          - libncurses5-dev
-          - libnfs-dev
-          - libnss3-dev
-          - libpixman-1-dev
-          - libpng-dev
-          - librados-dev
-          - libsdl2-dev
-          - libseccomp-dev
-          - liburcu-dev
-          - libusb-1.0-0-dev
-          - libvdeplug-dev
-          - libvte-2.91-dev
-          # Tests dependencies
-          - genisoimage
       env:
         - TEST_CMD="make check check-tcg V=1"
         - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS}"
-- 
2.24.1