From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8625DC34026 for ; Tue, 18 Feb 2020 09:57:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EC0F20659 for ; Tue, 18 Feb 2020 09:57:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iuFPcoJx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EC0F20659 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3zdW-0000aX-CT for qemu-devel@archiver.kernel.org; Tue, 18 Feb 2020 04:57:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44630) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3zVa-0001Cx-Jr for qemu-devel@nongnu.org; Tue, 18 Feb 2020 04:49:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3zVZ-0000K0-KP for qemu-devel@nongnu.org; Tue, 18 Feb 2020 04:49:38 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:43670 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j3zVZ-0000JZ-FA for qemu-devel@nongnu.org; Tue, 18 Feb 2020 04:49:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582019377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9bhLWeDmIRIbpw4WQFzMqL9ZUaH/2EcUzcdPU0bjoqQ=; b=iuFPcoJxrlC3KuSvnPZcWc+iKwNukwen7Br+geqjO0P2SdTdrbLSEOwquRK/Bog44enexP HABJDG1z6JnwrlEXWwlqTwkROErjT6rcQ1OTorvk0vgFY7sMLyIJXU9IMjOPdIXsHiedC6 e5qOFaW7FocOdxtIs07qPrWZABldFpY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-96-U8j75KKONqCjknlOdUajEA-1; Tue, 18 Feb 2020 04:49:35 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 857261B2C980; Tue, 18 Feb 2020 09:49:31 +0000 (UTC) Received: from work-vm (unknown [10.36.118.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E858619756; Tue, 18 Feb 2020 09:49:08 +0000 (UTC) Date: Tue, 18 Feb 2020 09:49:05 +0000 From: "Dr. David Alan Gilbert" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH RESEND 01/13] scripts/checkpatch.pl: Detect superfluous semicolon in C code Message-ID: <20200218094905.GC3080@work-vm> References: <20200218094402.26625-1-philmd@redhat.com> <20200218094402.26625-2-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200218094402.26625-2-philmd@redhat.com> User-Agent: Mutt/1.13.3 (2020-01-12) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: U8j75KKONqCjknlOdUajEA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Michael Tokarev , qemu-devel@nongnu.org, Gerd Hoffmann , "Edgar E. Iglesias" , qemu-block@nongnu.org, Juan Quintela , qemu-trivial@nongnu.org, Laurent Vivier , Thomas Huth , Eduardo Habkost , Alistair Francis , Julia Suvorova , Yuval Shaia , Alex Williamson , qemu-arm@nongnu.org, Stefan Hajnoczi , Aarushi Mehta , Richard Henderson , Kevin Wolf , Thomas Huth , Laurent Vivier , Max Reitz , Paolo Bonzini , Luc Michel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Philippe Mathieu-Daud=E9 (philmd@redhat.com) wrote: > Display error when a commit contains superfluous semicolon: >=20 > $ git show 6663a0a3376 | scripts/checkpatch.pl -q - > ERROR: superfluous trailing semicolon > #276: FILE: block/io_uring.c:186: > + ret =3D -ENOSPC;; > total: 1 errors, 1 warnings, 485 lines checked >=20 > Reported-by: Luc Michel > Signed-off-by: Philippe Mathieu-Daud=E9 Reviewed-by: Dr. David Alan Gilbert > --- > Cc: Paolo Bonzini > --- > scripts/checkpatch.pl | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index ce43a306f8..11512a8a09 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -1830,6 +1830,11 @@ sub process { > =09=09=09ERROR("suspicious ; after while (0)\n" . $herecurr); > =09=09} > =20 > +# Check superfluous trailing ';' > +=09=09if ($line =3D~ /;;$/) { > +=09=09=09ERROR("superfluous trailing semicolon\n" . $herecurr); > +=09=09} > + > # Check relative indent for conditionals and blocks. > =09=09if ($line =3D~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\= s*#/ && $line !~ /\}\s*while\s*/) { > =09=09=09my ($s, $c) =3D ($stat, $cond); > --=20 > 2.21.1 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK