From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 795ABC34026 for ; Tue, 18 Feb 2020 10:43:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 453E3206E2 for ; Tue, 18 Feb 2020 10:43:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fuB2Z2Ox" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 453E3206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j40Lb-0000iD-Fo for qemu-devel@archiver.kernel.org; Tue, 18 Feb 2020 05:43:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52286) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j40E9-0001w2-0E for qemu-devel@nongnu.org; Tue, 18 Feb 2020 05:35:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j40E6-0007WM-Kq for qemu-devel@nongnu.org; Tue, 18 Feb 2020 05:35:40 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:32093 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j40E6-0007W2-Hc for qemu-devel@nongnu.org; Tue, 18 Feb 2020 05:35:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582022137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qa1ssF0uaXNQpOeysKdHqIyaUPNzIgzDTTYOvuRRX4w=; b=fuB2Z2OxTUwSFF9yN5fD/E+t4L43ECjVN44mhe9VbdhhVJAqi9jboUwv8rqiVf8SXK4Z5z oPGmqIb4/4T5O97E8o/tW8OAPKKfCOHLOyrQ3DNzcMDl7geY9iWLAUpCjaCuYFGCCgo9XF GFXViXcDgzB+Ks08Wv7YAlLGprQqzdc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-FGtNsV5sOnqg4Rwz25zFKQ-1; Tue, 18 Feb 2020 05:35:33 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7762107ACC7; Tue, 18 Feb 2020 10:35:32 +0000 (UTC) Received: from localhost (unknown [10.36.118.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5CC6D87058; Tue, 18 Feb 2020 10:35:32 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v4 12/19] quorum: Stop marking it as a filter Date: Tue, 18 Feb 2020 11:34:47 +0100 Message-Id: <20200218103454.296704-13-mreitz@redhat.com> In-Reply-To: <20200218103454.296704-1-mreitz@redhat.com> References: <20200218103454.296704-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: FGtNsV5sOnqg4Rwz25zFKQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Quorum is not a filter, for example because it cannot guarantee which of its children will serve the next request. Thus, any of its children may differ from the data visible to quorum's parents. We have other filters with multiple children, but they differ in this aspect: - blkverify quits the whole qemu process if its children differ. As such, we can always skip it when we want to skip it (as a filter node) by going to any of its children. Both have the same data. - replication generally serves requests from bs->file, so this is its only actually filtered child. - Block job filters currently only have one child, but they will probably get more children in the future. Still, they will always have only one actually filtered child. Having "filters" as a dedicated node category only makes sense if you can skip them by going to a one fixed child that always shows the same data as the filter node. Quorum cannot fulfill this, so it is not a filter. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/quorum.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index f57b0402d9..6d7a56bd93 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -1198,7 +1198,6 @@ static BlockDriver bdrv_quorum =3D { =20 .bdrv_child_perm =3D quorum_child_perm, =20 - .is_filter =3D true, .bdrv_recurse_can_replace =3D quorum_recurse_can_replace, =20 .strong_runtime_opts =3D quorum_strong_runtime_opts, --=20 2.24.1