From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Sven Schnelle" <svens@stackframe.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PULL 5/9] hw/display/artist: Remove dead code (CID 1419388 & 1419389)
Date: Tue, 18 Feb 2020 11:39:25 -0800 [thread overview]
Message-ID: <20200218193929.11404-6-richard.henderson@linaro.org> (raw)
In-Reply-To: <20200218193929.11404-1-richard.henderson@linaro.org>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Coverity reports:
*** CID 1419388: Control flow issues (DEADCODE)
/hw/display/artist.c: 739 in draw_line_xy()
733 if (endy < 0) {
734 endy = 0;
735 }
736
737
738 if (endx < 0) {
>>> CID 1419388: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "return;".
739 return;
740 }
741
742 if (endy < 0) {
743 return;
744 }
*** CID 1419389: Control flow issues (DEADCODE)
/hw/display/artist.c: 743 in draw_line_xy()
737
738 if (endx < 0) {
739 return;
740 }
741
742 if (endy < 0) {
>>> CID 1419389: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "return;".
743 return;
744 }
745
746 trace_artist_draw_line(startx, starty, endx, endy);
747 draw_line(s, startx, starty, endx, endy, false, -1, -1);
748 }
Fixes: Covertiy CID 1419388 and 1419389 (commit 4765384ce33)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Sven Schnelle <svens@stackframe.org>
Message-Id: <20200214001303.12873-6-f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/display/artist.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index 5492079116..753dbb9a77 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -734,15 +734,6 @@ static void draw_line_xy(ARTISTState *s, bool update_start)
endy = 0;
}
-
- if (endx < 0) {
- return;
- }
-
- if (endy < 0) {
- return;
- }
-
draw_line(s, startx, starty, endx, endy, false, -1, -1);
}
--
2.20.1
next prev parent reply other threads:[~2020-02-18 19:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 19:39 [PULL 0/9] target/hppa patch queue Richard Henderson
2020-02-18 19:39 ` [PULL 1/9] hw/display/artist: Move trace event to draw_line() Richard Henderson
2020-02-18 19:39 ` [PULL 2/9] hw/display/artist: Remove pointless initialization Richard Henderson
2020-02-18 19:39 ` [PULL 3/9] hw/display/artist: Delay some variables initialization Richard Henderson
2020-02-18 19:39 ` [PULL 4/9] hw/display/artist: Avoid drawing line when nothing to display Richard Henderson
2020-02-29 9:31 ` Sven Schnelle
2020-03-02 9:50 ` Philippe Mathieu-Daudé
2020-02-18 19:39 ` Richard Henderson [this message]
2020-02-18 19:39 ` [PULL 6/9] hw/hppa/dino: Add comments with register name Richard Henderson
2020-02-18 19:39 ` [PULL 7/9] hw/hppa/dino: Fix reg800_keep_bits overrun (CID 1419387 1419393 1419394) Richard Henderson
2020-02-18 19:39 ` [PULL 8/9] hw/hppa/dino: Fix bitmask for the PCIROR register Richard Henderson
2020-02-18 19:39 ` [PULL 9/9] hw/hppa/dino: Do not accept accesses to registers 0x818 and 0x82c Richard Henderson
2020-02-20 16:51 ` [PULL 0/9] target/hppa patch queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218193929.11404-6-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).