From: "Longpeng(Mike)" <longpeng2@huawei.com>
To: <mst@redhat.com>, <alex.williamson@redhat.com>
Cc: longpeng2@huawei.com, arei.gonglei@huawei.com,
huangzhichao@huawei.com, qemu-devel@nongnu.org,
weifuqiang@huawei.com
Subject: [PATCH RESEND 2/3] vhost: fix a null pointer reference of vhost_log
Date: Mon, 24 Feb 2020 14:42:18 +0800 [thread overview]
Message-ID: <20200224064219.1434-3-longpeng2@huawei.com> (raw)
In-Reply-To: <20200224064219.1434-1-longpeng2@huawei.com>
From: Longpeng <longpeng2@huawei.com>
vhost_log_alloc() may fails and returned pointer of log is null.
However there're two places derefernce the return pointer without
check.
Signed-off-by: Longpeng <longpeng2@huawei.com>
---
hw/virtio/vhost.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 9edfadc..c7ad6e5 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -219,6 +219,10 @@ static struct vhost_log *vhost_log_get(uint64_t size, bool share)
if (!log || log->size != size) {
log = vhost_log_alloc(size, share);
+ if (!log) {
+ return NULL;
+ }
+
if (share) {
vhost_log_shm = log;
} else {
@@ -270,10 +274,17 @@ static bool vhost_dev_log_is_shared(struct vhost_dev *dev)
static inline void vhost_dev_log_resize(struct vhost_dev *dev, uint64_t size)
{
- struct vhost_log *log = vhost_log_get(size, vhost_dev_log_is_shared(dev));
- uint64_t log_base = (uintptr_t)log->log;
+ struct vhost_log *log;
+ uint64_t log_base;
int r;
+ log = vhost_log_get(size, vhost_dev_log_is_shared(dev));
+ if (!log) {
+ return;
+ }
+
+ log_base = (uintptr_t)log->log;
+
/* inform backend of log switching, this must be done before
releasing the current log, to ensure no logging is lost */
r = dev->vhost_ops->vhost_set_log_base(dev, log_base, log);
@@ -1640,6 +1651,10 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev)
hdev->log_size = vhost_get_log_size(hdev);
hdev->log = vhost_log_get(hdev->log_size,
vhost_dev_log_is_shared(hdev));
+ if (!hdev->log) {
+ goto fail_vq;
+ }
+
log_base = (uintptr_t)hdev->log->log;
r = hdev->vhost_ops->vhost_set_log_base(hdev,
hdev->log_size ? log_base : 0,
--
1.8.3.1
next prev parent reply other threads:[~2020-02-24 6:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 6:42 [PATCH RESEND 0/3] fix some warnings by static code scan tool Longpeng(Mike)
2020-02-24 6:42 ` [PATCH RESEND 1/3] vfio/pci: fix a null pointer reference in vfio_rom_read Longpeng(Mike)
2020-02-24 16:04 ` Alex Williamson
2020-02-24 23:48 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-03-10 16:11 ` Alex Williamson
2020-03-10 23:14 ` Laszlo Ersek
2020-03-11 1:36 ` Alex Williamson
2020-03-11 7:08 ` Markus Armbruster
2020-03-11 10:28 ` Laszlo Ersek
2020-03-11 10:26 ` Laszlo Ersek
2020-03-11 11:54 ` Markus Armbruster
2020-03-11 13:00 ` Laszlo Ersek
2020-03-11 7:04 ` Markus Armbruster
[not found] ` <20200311093939.494bfe27@w520.home>
2020-03-12 5:50 ` Markus Armbruster
2020-03-12 14:07 ` Alex Williamson
2020-02-24 6:42 ` Longpeng(Mike) [this message]
2020-03-10 2:11 ` [PATCH RESEND 2/3] vhost: fix a null pointer reference of vhost_log Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-03-10 5:57 ` Michael S. Tsirkin
2020-03-10 8:04 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-03-10 8:23 ` Michael S. Tsirkin
2020-03-10 12:02 ` Longpeng (Mike)
2020-03-10 12:18 ` Michael S. Tsirkin
2020-02-24 6:42 ` [PATCH RESEND 3/3] util/pty: fix a null pointer reference in qemu_openpty_raw Longpeng(Mike)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224064219.1434-3-longpeng2@huawei.com \
--to=longpeng2@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=huangzhichao@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weifuqiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).