From: Sebastien Boeuf <sebastien.boeuf@intel.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, sebastien.boeuf@intel.com,
berrange@redhat.com, stefanha@redhat.com, mst@redhat.com
Subject: [PATCH v2] docs: Update vhost-user spec regarding backend program conventions
Date: Mon, 24 Feb 2020 19:24:54 +0100 [thread overview]
Message-ID: <20200224182454.24610-1-sebastien.boeuf@intel.com> (raw)
The vhost-user specification is not clearly stating the expected
behavior from a backend program whenever the client disconnects.
This patch addresses the issue by defining the default behavior and
proposing an alternative through a command line option.
By default, a backend program will terminate whenever the client
disconnects, unless told otherwise through the newly introduced
option --keep-listening.
Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
docs/interop/vhost-user.rst | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst
index 5f8b3a456b..078f8e2e57 100644
--- a/docs/interop/vhost-user.rst
+++ b/docs/interop/vhost-user.rst
@@ -1323,6 +1323,10 @@ The backend program must end (as quickly and cleanly as possible) when
the SIGTERM signal is received. Eventually, it may receive SIGKILL by
the management layer after a few seconds.
+By default, the backend program terminates after the client disconnects.
+This is useful to keep the backend program's lifetime synchronized with
+its client process.
+
The following command line options have an expected behaviour. They
are mandatory, unless explicitly said differently:
@@ -1337,6 +1341,14 @@ are mandatory, unless explicitly said differently:
vhost-user socket as file descriptor FDNUM. It is incompatible with
--socket-path.
+--keep-listening
+
+ When this option is provided, the backend program must keep listening
+ after the client disconnects. It accepts only 1 connection at a time
+ on each UNIX domain socket. This prevents the management layer from
+ having to spawn a new backend program each and every time the client
+ disconnects.
+
--print-capabilities
Output to stdout the backend capabilities in JSON format, and then
--
2.20.1
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next reply other threads:[~2020-02-24 18:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 18:24 Sebastien Boeuf [this message]
2020-03-06 12:34 ` [PATCH v2] docs: Update vhost-user spec regarding backend program conventions Stefan Hajnoczi
2020-03-06 12:52 ` Marc-André Lureau
2020-03-11 14:19 ` Boeuf, Sebastien
2020-03-11 15:02 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224182454.24610-1-sebastien.boeuf@intel.com \
--to=sebastien.boeuf@intel.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).