From: Anthony PERARD <anthony.perard@citrix.com>
To: Juan Quintela <quintela@redhat.com>
Cc: Beata Michalska <beata.michalska@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] Memory: Only call ramblock_ptr when needed in qemu_ram_writeback
Date: Tue, 25 Feb 2020 16:02:03 +0000 [thread overview]
Message-ID: <20200225160203.GD2193@perard.uk.xensource.com> (raw)
In-Reply-To: <87immc190v.fsf@trasno.org>
On Thu, Dec 19, 2019 at 07:10:24PM +0100, Juan Quintela wrote:
> Anthony PERARD <anthony.perard@citrix.com> wrote:
> > It is possible that a ramblock doesn't have memory that QEMU can
> > access, this is the case with the Xen hypervisor.
> >
> > In order to avoid to trigger an assert, only call ramblock_ptr() when
> > needed in qemu_ram_writeback(). This should fix migration of Xen
> > guests that was broken with bd108a44bc29 ("migration: ram: Switch to
> > ram block writeback").
> >
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> This is exec.c, nothing related to migration.
>
> Paolo, are you taking this one?
> It could even go through the trivial one.
Hi,
I'm going to send a pull request for the xen queue with this patch.
Unless that's an issue?
Cheers,
--
Anthony PERARD
next prev parent reply other threads:[~2020-02-25 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 15:42 Recent change pmem related breaks Xen migration Anthony PERARD
2019-12-19 15:43 ` [PATCH] Memory: Only call ramblock_ptr when needed in qemu_ram_writeback Anthony PERARD
2019-12-19 17:31 ` Beata Michalska
2019-12-19 18:10 ` Juan Quintela
2020-02-25 16:02 ` Anthony PERARD [this message]
2020-02-25 16:51 ` Paolo Bonzini
2019-12-19 17:40 ` Recent change pmem related breaks Xen migration Beata Michalska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225160203.GD2193@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=beata.michalska@linaro.org \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).