* [PATCH] Arithmetic error fixed in EDID generation
@ 2020-02-25 20:09 Anton V. Boyarshinov
0 siblings, 0 replies; only message in thread
From: Anton V. Boyarshinov @ 2020-02-25 20:09 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: shaba, qemu-devel
To compute screen size in centimeters we should calculate:
pixels/dpi*2.54
but not
pixels*dpi/2540
Using wrong formula we actually get 65 DPI and very small fonts.
Signed-off-by: Anton V. Boyarshinov <boyarsh@altlinux.org>
---
hw/display/edid-generate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/display/edid-generate.c b/hw/display/edid-generate.c
index 75c945a948..537e063662 100644
--- a/hw/display/edid-generate.c
+++ b/hw/display/edid-generate.c
@@ -360,8 +360,8 @@ void qemu_edid_generate(uint8_t *edid, size_t size,
edid[20] = 0xa5;
/* screen size: undefined */
- edid[21] = info->prefx * info->dpi / 2540;
- edid[22] = info->prefy * info->dpi / 2540;
+ edid[21] = (uint8_t) ((float) info->prefx / info->dpi * 2.54);
+ edid[22] = (uint8_t) ((float) info->prefy / info->dpi * 2.54);
/* display gamma: 2.2 */
edid[23] = 220 - 100;
--
2.21.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-25 23:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-25 20:09 [PATCH] Arithmetic error fixed in EDID generation Anton V. Boyarshinov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).