From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Igor Kotrasinski <i.kotrasinsk@partner.samsung.com>,
David Hildenbrand <david@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Peter Xu <peterx@redhat.com>,
Murilo Opsfelder Araujo <muriloo@linux.ibm.com>,
Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: [PATCH v3 05/15] exec: Reuse qemu_ram_apply_settings() in qemu_ram_remap()
Date: Thu, 27 Feb 2020 11:11:55 +0100 [thread overview]
Message-ID: <20200227101205.5616-6-david@redhat.com> (raw)
In-Reply-To: <20200227101205.5616-1-david@redhat.com>
I don't see why we shouldn't apply all settings to make it look like the
surrounding RAM (and enable proper VMA merging).
Note: memory backend settings might have overridden these settings. We
would need a callback to let the memory backend fix that up.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
exec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/exec.c b/exec.c
index a0a8d93fee..1fc1fa237e 100644
--- a/exec.c
+++ b/exec.c
@@ -2516,8 +2516,7 @@ void qemu_ram_remap(ram_addr_t addr, ram_addr_t length)
length, addr);
exit(1);
}
- memory_try_enable_merging(vaddr, length);
- qemu_ram_setup_dump(vaddr, length);
+ qemu_ram_apply_settings(vaddr, length);
}
}
}
--
2.24.1
next prev parent reply other threads:[~2020-02-27 10:18 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 10:11 [PATCH v3 00/15] Ram blocks with resizeable anonymous allocations under POSIX David Hildenbrand
2020-02-27 10:11 ` [PATCH v3 01/15] util: vfio-helpers: Fix qemu_vfio_close() David Hildenbrand
2020-02-27 10:11 ` [PATCH v3 02/15] util: vfio-helpers: Remove Error parameter from qemu_vfio_undo_mapping() David Hildenbrand
2020-02-27 10:11 ` [PATCH v3 03/15] util: vfio-helpers: Factor out removal " David Hildenbrand
2020-02-27 10:11 ` [PATCH v3 04/15] exec: Factor out setting ram settings (madvise ...) into qemu_ram_apply_settings() David Hildenbrand
2020-02-27 10:11 ` David Hildenbrand [this message]
2020-02-27 10:11 ` [PATCH v3 06/15] exec: Drop "shared" parameter from ram_block_add() David Hildenbrand
2020-02-27 10:11 ` [PATCH v3 07/15] util/mmap-alloc: Factor out calculation of the pagesize for the guard page David Hildenbrand
2020-02-28 19:43 ` Peter Xu
2020-02-27 10:11 ` [PATCH v3 08/15] util/mmap-alloc: Factor out reserving of a memory region to mmap_reserve() David Hildenbrand
2020-02-27 10:11 ` [PATCH v3 09/15] util/mmap-alloc: Factor out populating of memory to mmap_populate() David Hildenbrand
2020-03-03 8:43 ` David Hildenbrand
2020-02-27 10:12 ` [PATCH v3 10/15] util/mmap-alloc: Prepare for resizeable mmaps David Hildenbrand
2020-02-27 10:12 ` [PATCH v3 11/15] util/mmap-alloc: Implement " David Hildenbrand
2020-02-28 19:43 ` Peter Xu
2020-02-27 10:12 ` [PATCH v3 12/15] util: vfio-helpers: Implement ram_block_resized() David Hildenbrand
2020-02-28 19:42 ` Peter Xu
2020-02-28 20:16 ` David Hildenbrand
2020-02-28 21:01 ` Peter Xu
2020-03-02 15:01 ` David Hildenbrand
2020-02-28 19:55 ` Peter Xu
2020-02-28 20:19 ` David Hildenbrand
2020-02-28 20:49 ` Peter Xu
2020-02-28 20:56 ` David Hildenbrand
2020-02-27 10:12 ` [PATCH v3 13/15] util: oslib: Resizeable anonymous allocations under POSIX David Hildenbrand
2020-02-28 20:11 ` Peter Xu
2020-02-27 10:12 ` [PATCH v3 14/15] numa: Introduce ram_block_notifiers_support_resize() David Hildenbrand
2020-02-28 20:11 ` Peter Xu
2020-02-27 10:12 ` [PATCH v3 15/15] exec: Ram blocks with resizeable anonymous allocations under POSIX David Hildenbrand
2020-02-28 20:21 ` Peter Xu
2020-03-02 15:27 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227101205.5616-6-david@redhat.com \
--to=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=i.kotrasinsk@partner.samsung.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=muriloo@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).