* [PATCH] qapi/machine: Place the 'Notes' tag after the 'Since' tag
@ 2020-02-27 10:41 Philippe Mathieu-Daudé
2020-02-27 11:59 ` Liam Merwick
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-27 10:41 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Eduardo Habkost, Markus Armbruster
This fixes when adding a 'Since' tag:
In file included from qapi/qapi-schema.json:105:
qapi/machine.json:25:1: '@arch:' can't follow 'Notes' section
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
qapi/machine.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index 6c11e3cf3a..2b4f5f0962 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -16,11 +16,11 @@
# individual target constants are not documented here, for the time
# being.
#
+# Since: 3.0
+#
# Notes: The resulting QMP strings can be appended to the "qemu-system-"
# prefix to produce the corresponding QEMU executable name. This
# is true even for "qemu-system-x86_64".
-#
-# Since: 3.0
##
{ 'enum' : 'SysEmuTarget',
'data' : [ 'aarch64', 'alpha', 'arm', 'cris', 'hppa', 'i386', 'lm32',
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qapi/machine: Place the 'Notes' tag after the 'Since' tag
2020-02-27 10:41 [PATCH] qapi/machine: Place the 'Notes' tag after the 'Since' tag Philippe Mathieu-Daudé
@ 2020-02-27 11:59 ` Liam Merwick
2020-02-27 13:39 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Liam Merwick @ 2020-02-27 11:59 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Eduardo Habkost, Markus Armbruster
On 27/02/2020 10:41, Philippe Mathieu-Daudé wrote:
> This fixes when adding a 'Since' tag:
>
> In file included from qapi/qapi-schema.json:105:
> qapi/machine.json:25:1: '@arch:' can't follow 'Notes' section
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> qapi/machine.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 6c11e3cf3a..2b4f5f0962 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -16,11 +16,11 @@
> # individual target constants are not documented here, for the time
> # being.
> #
> +# Since: 3.0
> +#
> # Notes: The resulting QMP strings can be appended to the "qemu-system-"
> # prefix to produce the corresponding QEMU executable name. This
> # is true even for "qemu-system-x86_64".
> -#
> -# Since: 3.0
> ##
> { 'enum' : 'SysEmuTarget',
> 'data' : [ 'aarch64', 'alpha', 'arm', 'cris', 'hppa', 'i386', 'lm32',
>
Does the same issue occur for @CpuInstanceProperties: at line 829?
The 'Since:' follows a 'Note:' section (but maybe the singular usage is
intended).
otherwise
Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qapi/machine: Place the 'Notes' tag after the 'Since' tag
2020-02-27 11:59 ` Liam Merwick
@ 2020-02-27 13:39 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-27 13:39 UTC (permalink / raw)
To: Liam Merwick, qemu-devel; +Cc: Eduardo Habkost, Markus Armbruster
On 2/27/20 12:59 PM, Liam Merwick wrote:
> On 27/02/2020 10:41, Philippe Mathieu-Daudé wrote:
>> This fixes when adding a 'Since' tag:
>>
>> In file included from qapi/qapi-schema.json:105:
>> qapi/machine.json:25:1: '@arch:' can't follow 'Notes' section
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> qapi/machine.json | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/qapi/machine.json b/qapi/machine.json
>> index 6c11e3cf3a..2b4f5f0962 100644
>> --- a/qapi/machine.json
>> +++ b/qapi/machine.json
>> @@ -16,11 +16,11 @@
>> # individual target constants are not documented here, for the time
>> # being.
>> #
>> +# Since: 3.0
>> +#
>> # Notes: The resulting QMP strings can be appended to the
>> "qemu-system-"
>> # prefix to produce the corresponding QEMU executable name. This
>> # is true even for "qemu-system-x86_64".
>> -#
>> -# Since: 3.0
>> ##
>> { 'enum' : 'SysEmuTarget',
>> 'data' : [ 'aarch64', 'alpha', 'arm', 'cris', 'hppa', 'i386', 'lm32',
>>
>
>
> Does the same issue occur for @CpuInstanceProperties: at line 829?
> The 'Since:' follows a 'Note:' section (but maybe the singular usage is
> intended).
Ah thanks for checking other cases. Yes, the same error should occur.
>
> otherwise
>
> Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
Thanks! I'll respin with the other entry fixed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-27 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-27 10:41 [PATCH] qapi/machine: Place the 'Notes' tag after the 'Since' tag Philippe Mathieu-Daudé
2020-02-27 11:59 ` Liam Merwick
2020-02-27 13:39 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).