From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v2] qapi/machine: Place the 'Notes' tag after the 'Since' tag
Date: Thu, 27 Feb 2020 14:40:19 +0100 [thread overview]
Message-ID: <20200227134019.6218-1-philmd@redhat.com> (raw)
This fixes when adding a 'Since' tag:
In file included from qapi/qapi-schema.json:105:
qapi/machine.json:25:1: '@arch:' can't follow 'Notes' section
Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: Fix another occurrence in CpuInstanceProperties (Liam Merwick)
---
qapi/machine.json | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index 6c11e3cf3a..3d8b5324f3 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -16,11 +16,11 @@
# individual target constants are not documented here, for the time
# being.
#
+# Since: 3.0
+#
# Notes: The resulting QMP strings can be appended to the "qemu-system-"
# prefix to produce the corresponding QEMU executable name. This
# is true even for "qemu-system-x86_64".
-#
-# Since: 3.0
##
{ 'enum' : 'SysEmuTarget',
'data' : [ 'aarch64', 'alpha', 'arm', 'cris', 'hppa', 'i386', 'lm32',
@@ -820,13 +820,13 @@
# @die-id: die number within node/board the CPU belongs to (Since 4.1)
# @core-id: core number within die the CPU belongs to# @thread-id: thread number within core the CPU belongs to
#
+# Since: 2.7
+#
# Note: currently there are 5 properties that could be present
# but management should be prepared to pass through other
# properties with device_add command to allow for future
# interface extension. This also requires the filed names to be kept in
# sync with the properties passed to -device/device_add.
-#
-# Since: 2.7
##
{ 'struct': 'CpuInstanceProperties',
'data': { '*node-id': 'int',
--
2.21.1
next reply other threads:[~2020-02-27 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 13:40 Philippe Mathieu-Daudé [this message]
2020-02-27 14:52 ` [PATCH v2] qapi/machine: Place the 'Notes' tag after the 'Since' tag Markus Armbruster
2020-02-27 14:55 ` Philippe Mathieu-Daudé
2020-02-27 15:21 ` Philippe Mathieu-Daudé
2020-02-27 20:14 ` Eduardo Habkost
2020-02-28 6:56 ` Markus Armbruster
2020-02-28 10:17 ` Philippe Mathieu-Daudé
2020-02-28 17:34 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227134019.6218-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).