From: Peter Xu <peterx@redhat.com>
To: Auger Eric <eric.auger@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 0/5] vfio/pci: Fix up breakage against split irqchip and INTx
Date: Thu, 27 Feb 2020 12:02:14 -0500 [thread overview]
Message-ID: <20200227170214.GG180973@xz-x1> (raw)
In-Reply-To: <20200227155146.GD180973@xz-x1>
On Thu, Feb 27, 2020 at 10:51:46AM -0500, Peter Xu wrote:
> Right. Another thing I just noticed is that we must _not_ attach the
> resamplefd to the KVM_IRQFD ioctl when we registered this in the
> userspace. One thing is it's for sure not needed at all. More
> importantly, on new kernels (after commit 654f1f13ea56) the KVM_IRQFD
> could fail (because it sees both split irqchip and resamplefd) and
> QEMU will fallback again to the slow path even if the fast path can
> work.
I've just posted a v1.1 version of patch 4 only, which should fix this
problem on new kernels, so fast path will always be preferred. The
only changed function is kvm_irqchip_assign_irqfd().
--
Peter Xu
next prev parent reply other threads:[~2020-02-27 17:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 22:50 [PATCH 0/5] vfio/pci: Fix up breakage against split irqchip and INTx Peter Xu
2020-02-26 22:50 ` [PATCH 1/5] vfio/pci: Disable INTx fast path if using split irqchip Peter Xu
2020-02-27 16:53 ` Auger Eric
2020-02-27 17:10 ` Peter Xu
2020-02-26 22:50 ` [PATCH 2/5] vfio/pci: Use kvm_irqchip_add_irqfd_notifier_gsi() for irqfds Peter Xu
2020-02-27 11:04 ` Auger Eric
2020-02-27 16:41 ` Cornelia Huck
2020-02-26 22:54 ` [PATCH 3/5] KVM: Pass EventNotifier into kvm_irqchip_assign_irqfd Peter Xu
2020-02-27 17:01 ` Auger Eric
2020-02-26 22:55 ` [PATCH 4/5] KVM: Kick resamplefd for split kernel irqchip Peter Xu
2020-02-27 17:00 ` [PATCH v1.1 " Peter Xu
2020-02-27 17:18 ` Peter Xu
2020-02-27 17:42 ` Auger Eric
2020-02-27 18:00 ` Peter Xu
2020-02-27 18:22 ` Auger Eric
2020-02-27 19:19 ` Peter Xu
2020-02-27 21:14 ` Auger Eric
2020-02-27 21:52 ` Peter Xu
2020-02-28 10:34 ` Paolo Bonzini
2020-02-28 10:36 ` Auger Eric
2020-02-28 10:34 ` [PATCH " Paolo Bonzini
2020-02-28 14:58 ` Peter Xu
2020-02-28 15:24 ` Paolo Bonzini
2020-02-26 22:55 ` [PATCH 5/5] Revert "vfio/pci: Disable INTx fast path if using split irqchip" Peter Xu
2020-02-27 15:32 ` [PATCH 0/5] vfio/pci: Fix up breakage against split irqchip and INTx Auger Eric
2020-02-27 15:51 ` Peter Xu
2020-02-27 17:02 ` Peter Xu [this message]
2020-02-28 10:36 ` Paolo Bonzini
2020-02-28 15:25 ` Peter Xu
2020-02-28 15:32 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227170214.GG180973@xz-x1 \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).