From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-trivial@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"John Snow" <jsnow@redhat.com>
Subject: [PATCH v2 10/18] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
Date: Fri, 28 Feb 2020 12:46:41 +0100 [thread overview]
Message-ID: <20200228114649.12818-11-philmd@redhat.com> (raw)
In-Reply-To: <20200228114649.12818-1-philmd@redhat.com>
hw/acpi/cpu_hotplug.c calls pci_address_space_io(). Include
"hw/pci/pci.h" which declares it.
This fixes (when modifying unrelated headers):
hw/acpi/cpu_hotplug.c:103:28: error: implicit declaration of function 'pci_address_space_io' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
MemoryRegion *parent = pci_address_space_io(PCI_DEVICE(gpe_cpu->device));
^
Acked-by: John Snow <jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/acpi/cpu_hotplug.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_hotplug.c
index 9c3bcc84de..3e687d227a 100644
--- a/hw/acpi/cpu_hotplug.c
+++ b/hw/acpi/cpu_hotplug.c
@@ -14,6 +14,7 @@
#include "qapi/error.h"
#include "hw/core/cpu.h"
#include "hw/i386/pc.h"
+#include "hw/pci/pci.h"
#include "qemu/error-report.h"
#define CPU_EJECT_METHOD "CPEJ"
--
2.21.1
next prev parent reply other threads:[~2020-02-28 11:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 11:46 [PATCH v2 00/18] hw: Clean up hw/i386 headers (and few alpha/hppa) Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 01/18] vl: Add missing "hw/boards.h" include Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 02/18] hw/southbridge/ich9: Removed unused headers Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 03/18] hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 04/18] hw/timer: Remove unused "ui/console.h" header Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 05/18] hw/usb/dev-storage: " Philippe Mathieu-Daudé
2020-02-28 13:19 ` Gerd Hoffmann
2020-02-28 11:46 ` [PATCH v2 06/18] hw/i386/intel_iommu: Remove unused includes Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 07/18] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 08/18] hw/alpha/dp264: Include "net/net.h" Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 09/18] hw/hppa/machine: " Philippe Mathieu-Daudé
2020-02-28 11:46 ` Philippe Mathieu-Daudé [this message]
2020-02-28 11:46 ` [PATCH v2 11/18] hw/timer/hpet: Include "exec/address-spaces.h" Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 12/18] hw/pci-host/q35: Include "qemu/range.h" Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 13/18] hw/i2c/smbus_ich9: " Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 14/18] hw/pci-host/piix: " Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 15/18] hw/acpi: Include "hw/mem/nvdimm.h" Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 16/18] hw/i386: " Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 17/18] hw/pci-host/q35: Remove unused includes Philippe Mathieu-Daudé
2020-02-28 11:46 ` [PATCH v2 18/18] hw/i386/pc: Clean up includes Philippe Mathieu-Daudé
2020-02-29 19:53 ` [PATCH v2 00/18] hw: Clean up hw/i386 headers (and few alpha/hppa) Richard Henderson
2020-03-09 11:56 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228114649.12818-11-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).