From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Jan Kiszka" <jan.kiszka@web.de>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH 4/5] hw/arm/z2: Simplify since the machines are little-endian only
Date: Fri, 28 Feb 2020 13:53:50 +0100 [thread overview]
Message-ID: <20200228125351.29482-5-philmd@redhat.com> (raw)
In-Reply-To: <20200228125351.29482-1-philmd@redhat.com>
We only build the little-endian softmmu configurations. Checking
for big endian is pointless, remove the unused code.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/arm/z2.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/hw/arm/z2.c b/hw/arm/z2.c
index 4bb237f22d..a0f4095990 100644
--- a/hw/arm/z2.c
+++ b/hw/arm/z2.c
@@ -300,7 +300,6 @@ static void z2_init(MachineState *machine)
uint32_t sector_len = 0x10000;
PXA2xxState *mpu;
DriveInfo *dinfo;
- int be;
void *z2_lcd;
I2CBus *bus;
DeviceState *wm;
@@ -308,15 +307,10 @@ static void z2_init(MachineState *machine)
/* Setup CPU & memory */
mpu = pxa270_init(address_space_mem, z2_binfo.ram_size, machine->cpu_type);
-#ifdef TARGET_WORDS_BIGENDIAN
- be = 1;
-#else
- be = 0;
-#endif
dinfo = drive_get(IF_PFLASH, 0, 0);
if (!pflash_cfi01_register(Z2_FLASH_BASE, "z2.flash0", Z2_FLASH_SIZE,
dinfo ? blk_by_legacy_dinfo(dinfo) : NULL,
- sector_len, 4, 0, 0, 0, 0, be)) {
+ sector_len, 4, 0, 0, 0, 0, 0)) {
error_report("Error registering flash memory");
exit(1);
}
--
2.21.1
next prev parent reply other threads:[~2020-02-28 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 12:53 [PATCH 0/5] hw/arm: Remove big-endian checks on machine code Philippe Mathieu-Daudé
2020-02-28 12:53 ` [PATCH 1/5] hw/arm/gumstix: Simplify since the machines are little-endian only Philippe Mathieu-Daudé
2020-02-28 12:53 ` [PATCH 2/5] hw/arm/mainstone: " Philippe Mathieu-Daudé
2020-02-28 12:53 ` [PATCH 3/5] hw/arm/omap_sx1: " Philippe Mathieu-Daudé
2020-02-28 12:53 ` Philippe Mathieu-Daudé [this message]
2020-02-28 12:53 ` [PATCH 5/5] hw/arm/musicpal: " Philippe Mathieu-Daudé
2020-02-29 19:38 ` [PATCH 0/5] hw/arm: Remove big-endian checks on machine code Richard Henderson
2020-03-02 11:44 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228125351.29482-5-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=jan.kiszka@web.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).