From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FBDEC3F2C6 for ; Sat, 29 Feb 2020 09:34:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 393062072A for ; Sat, 29 Feb 2020 09:34:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=duncanthrax.net header.i=@duncanthrax.net header.b="mO/fhzCR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 393062072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stackframe.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7yWG-0000IU-5F for qemu-devel@archiver.kernel.org; Sat, 29 Feb 2020 04:34:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43444) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7ySq-00089j-Sh for qemu-devel@nongnu.org; Sat, 29 Feb 2020 04:31:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7ySp-0003wu-QB for qemu-devel@nongnu.org; Sat, 29 Feb 2020 04:31:16 -0500 Received: from smtp.duncanthrax.net ([178.63.180.169]:33408) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7ySp-0003wL-9A for qemu-devel@nongnu.org; Sat, 29 Feb 2020 04:31:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=duncanthrax.net; s=dkim; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4I+ZZeTyv3mwNKB+CpUOsv3dk7ZZGuP91LvgBxwJV/s=; b=mO/fhzCRGjt17t5EZGjbzpZzgE Wo7zWziRdoAWLG6WRT5Sev9rLlN0scr4uoxfy1F+ooB8ty/bUZbRTKXQ6Q8x8OZR9HPQJEn8wWOdN DlnpYJ6v43f4+YYktoT3CJEfdIABxV4tLQagxd6yoRre5CUO04/Dgzw0dZejHhsUoL6g=; Received: from [134.3.47.90] (helo=t470p.stackframe.org) by smtp.duncanthrax.net with esmtpa (Exim 4.90_1) (envelope-from ) id 1j7ySm-0005TE-2l; Sat, 29 Feb 2020 10:31:12 +0100 Date: Sat, 29 Feb 2020 10:31:11 +0100 From: Sven Schnelle To: Richard Henderson Subject: Re: [PULL 4/9] hw/display/artist: Avoid drawing line when nothing to display Message-ID: <20200229093111.GA24534@t470p.stackframe.org> References: <20200218193929.11404-1-richard.henderson@linaro.org> <20200218193929.11404-5-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200218193929.11404-5-richard.henderson@linaro.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 178.63.180.169 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Feb 18, 2020 at 11:39:24AM -0800, Richard Henderson wrote: > From: Philippe Mathieu-Daudé > > Signed-off-by: Philippe Mathieu-Daudé > Message-Id: <20200214001303.12873-5-f4bug@amsat.org> > Signed-off-by: Richard Henderson > --- > hw/display/artist.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/display/artist.c b/hw/display/artist.c > index 97c811b35e..5492079116 100644 > --- a/hw/display/artist.c > +++ b/hw/display/artist.c > @@ -579,6 +579,9 @@ static void draw_line(ARTISTState *s, int x1, int y1, int x2, int y2, > } else { > dy = y1 - y2; > } > + if (!dx || !dy) { > + return; > + } > > c1 = false; > if (dy > dx) { > -- > 2.20.1 > > I noticed that this change causes 1px wide lines to disappear. So i would propose to revert that change. Regards Sven